Review 11.5 Abandoned

79444[TASK] Default sort-by UID

TYPO3com CR 0 V 0 Easy +1 −1 updated 08/06/24, 14:50

Commit message

the field "file" is not existent and causes the List to fetch all File
Properties from database without any success for the property

`FileList.php
default: $sortingKey = $file->hasProperty($this->sort) ?
(string)$file->getProperty($this->sort) : '';`

Makes many unnecessary db calls

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 46

  1. TYPO3com uploaded patch set 1 06/16/23, 12:50

  2. core-ci voted on patch set 1 V +1 06/16/23, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42742

  3. Tymoteusz Motylewski commented on patch set 1 06/16/23, 13:19

    The code in v12 is different (moduleData object is used which is created from request $this->moduleData = $request->getAttribute('moduleData'). So it needs to be checked whether the issue exists in v12/main also, or just in v11.
  4. Benni Mack commented on patch set 1 07/04/23, 13:41

    ping?
  5. Christian Kuhn commented on patch set 1 08/06/24, 14:50

    hey. i'm abandoning here for now since this patch is stalled and without further feedback. i hope this is ok. please create a fresh patch for main in case this is still an issue.
  6. Christian Kuhn abandoned the change 08/06/24, 14:50