Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

79450[WIP][BUGFIX] Cascade remove will also remove hidden childs

Stefan Froemken CR 0 V 0 Easy +14 −0 updated 03/22/25, 13:04

Commit message

When deleting child objects that are located in
an ObjectStorage that is marked with Cascade remove,
the hidden child objects are now also deleted to
prevent orphan records in the database.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 4
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/50/79450/4 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/50/79450/4 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 1

Review log 1014

  1. Stefan Froemken uploaded patch set 1 06/16/23, 23:15

  2. Stefan Froemken commented on patch set 1 06/16/23, 23:19

    This is just a first try, but working example to also remove hidden child objects, if cascade remove is active. I don't know, if this is a good place to do so, that's why this patch is marked WIP. Please let us discuss this or a better way. Feel free to take over this patch.
  3. core-ci voted on patch set 1 V +1 06/16/23, 23:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42762

  4. Benni Mack commented on patch set 1 06/16/23, 23:38

    YEAH!
  5. Oliver Klee commented on patch set 1 06/17/23, 08:09

    Backend.php:900

    Does this problem also affect the starttime/endtime fields?
  6. Oliver Klee wrote 08/25/24, 10:14

    Removed cc Oliver Klee.
  7. Benni Mack uploaded patch set 2 V +1 01/31/25, 07:08

  8. Benni Mack rebased onto patch set 3 01/31/25, 07:09

  9. Benni Mack commented on patch set 3 01/31/25, 07:10

    Backend.php:900 Reply

    yes. fixed.
  10. core-ci voted on patch set 2 V +1 01/31/25, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73238

  11. core-ci voted on patch set 3 V +1 01/31/25, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73240

  12. Benni Mack uploaded patch set 4 V +1 03/11/25, 10:32

  13. core-ci voted on patch set 4 V +1 03/11/25, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75470

  14. Benni Mack marked it work in progress 03/22/25, 13:04