Review main Merged

79481[BUGFIX] Declare FormEngine NodeInterface classes stateful

Christian Kuhn CR +2 V +2 Easy +8 −1 updated 06/22/23, 12:28

Commit message

FormEngine classes implementing NodeInterface are DI
aware since #101103. They need to be declared stateful
(aka "shared: false", non singleton) since they may have
state, or depend on other stateful services, an example
is the InlineStackProcessor. A new object needs to be
built each time, otherwise various funny things can occur.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1