79482[!!!][TASK] Mark class PageRenderer as final
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 2
Review log 78
-
Thomas Hohn uploaded patch set 1 06/22/23, 12:29
-
core-ci voted on patch set 1 V -1 06/22/23, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42910
-
Chris Müller commented on patch set 1 06/22/23, 12:49
That means that I cannot mock PageRenderer easily. Maybe introduce an interface? -
Christian Kuhn commented on patch set 1 06/22/23, 14:54
yeah. final may be a bit hard to achieve at the moment without interface. and on the other hand, we may not want to hard-nail an interface for this, currently, since the pageRenderer should continue to slim down and simplify further, first, i suppose. -
Thomas Hohn commented on patch set 1 06/22/23, 15:23
Reply
So should we just skip this? Or change the comment to make it final in v14? -
Thomas Hohn commented on patch set 1 08/01/23, 11:59
Reply
Any comments to the above @lolli ? -
Christian Kuhn commented on patch set 1 08/02/23, 16:49
Reply Unresolved
yeah. let's abandon and close issue for now. -
Christian Kuhn abandoned the change 08/02/23, 16:51