79491[BUGFIX] Add `ESCAPE` keyword for `like()` and `notLike() expressions
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
-
Verified V +2 Done
- Stefan Bürk +2
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Database/Query/Expression/ExpressionBuilder.php4+4 −2
- typo3/sysext/core/Tests/Functional/Database/Fixtures/DataSet/TestExpressionBuilderLikeAndNotLike.csv+3 −0
- typo3/sysext/core/Tests/Functional/Database/Query/Expression/ExpressionBuilderTest.php+130 −2
- typo3/sysext/core/Tests/Unit/Database/Query/Expression/ExpressionBuilderTest.php+36 −15
- typo3/sysext/indexed_search/Tests/Functional/Utility/LikeWildcardTest.php+3 −0
Review log 79
-
Stefan Bürk uploaded patch set 1 06/25/23, 22:03
-
core-ci voted on patch set 1 V -1 06/25/23, 22:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42970
-
Stefan Bürk uploaded patch set 2
V -106/26/23, 04:34 -
core-ci voted on patch set 2 V +1 06/26/23, 04:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42975
-
Stefan Bürk voted on patch set 2 V +2 CR +2 06/26/23, 05:23
-
Stefan Bürk merged patch set 3 06/26/23, 05:23
-
Andreas Kienast commented on patch set 3 06/28/23, 08:45
post -1ExpressionBuilder.php:248Isn't the `ESCAPE` stuff missing here as well?ExpressionBuilder.php:268Isn't the `ESCAPE` stuff missing here as well? -
Andreas Kienast commented on patch set 3 06/28/23, 08:49
Never mind, I found the information in the commit message...ExpressionBuilder.php:248ReplyDoneExpressionBuilder.php:268ReplyDone -
Stefan Bürk commented on patch set 3 06/28/23, 18:15
Reply
;)