Review main Merged

79513[TASK] Deprecate class Enumeration

Thomas Hohn CR +2 V +2 Normal +77 −36 updated 12/09/23, 16:48

Commit message

The class \TYPO3\CMS\Core\Type\Enumeration
is deprecated in favor of PHP native backed enums.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 4053

Show 2228 earlier messages
  1. Thomas Hohn uploaded patch set 1 06/27/23, 05:29

  2. core-ci voted on patch set 1 V +1 06/27/23, 05:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43005

  3. Mathias Brodala commented on patch set 1 06/27/23, 07:23

    Enumeration.php:51

    I'd insert this here: ... used by ' . static::class . ' ... This way it is very easy to find the offending 3rd party enum.
  4. Thomas Hohn uploaded patch set 2 V +1 06/28/23, 05:49

  5. core-ci voted on patch set 2 V +1 06/28/23, 05:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43056

  6. Thomas Hohn commented on patch set 2 06/28/23, 05:57

    Enumeration.php:51 Reply

    Done
  7. Mathias Brodala commented on patch set 2 06/28/23, 08:18

    Enumeration.php:51

    There's a space missing here. 😋 Also we should probably use "used by enumeration" to be consistent with the errors below.
  8. Thomas Hohn uploaded patch set 3 V +1 07/03/23, 04:45

  9. Thomas Hohn commented on patch set 2 07/03/23, 04:45

    Enumeration.php:51 Reply

    Done
  10. core-ci voted on patch set 3 V +1 07/03/23, 04:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43201

  11. Oliver Klee updated the commit message in patch set 4 V +1 07/03/23, 08:55

  12. core-ci voted on patch set 4 V +1 07/03/23, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43203

  13. Oliver Klee commented on patch set 4 07/19/23, 16:57

    Is this ready to review, or do we still need to remove some occurrences?
  14. Chris Müller uploaded patch set 5 V +1 07/19/23, 17:41

  15. core-ci voted on patch set 5 V +1 07/19/23, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44316

  16. Alexander Schnitzler commented on patch set 5 07/20/23, 06:49

    First of all: Good idea! BUT: Extbase is not yet capable of handling native enums but it was able to map those fake enums for years. If we take that away, we should have a migration path available.
  17. Thomas Hohn commented on patch set 5 07/24/23, 19:03

    Reply

    It could be reviewed - however there are still some PR's that haven't been merged yet.
  18. Thomas Hohn commented on patch set 5 07/24/23, 19:04

    Reply

    okay - any suggestions would be appreciated 😊
  19. Oliver Klee commented on patch set 5 07/24/23, 19:57

    Reply

    There still is hope. ;-) Alexander Schnitzler has provided an implementation for handling native enums in Extbase. Reviewing and testing this change will help bring things forward: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80099 I propose to set this change here to WIP and rebase after Alexander’s change has been merged. What do you think?
  20. Oliver Klee commented on patch set 5 07/24/23, 20:16

    Reply

    Ah, Alexander’s change is still WIP. Maybe we still can help.
  21. Alexander Schnitzler commented on patch set 5 07/25/23, 05:39

    Reply

    My patch isn't a necessity for this patch to be merged. Overall, the Enumeration class is just deprecated, not removed. I will take care of the native enum implementation this week, we will have both ready for 13.0. I mark this resolved.
  22. Oliver Klee voted on patch set 5 V +1 CR +1 07/25/23, 07:43

  23. Nikita Hovratov uploaded patch set 6 CR +1 V +1 07/25/23, 15:41

  24. Oliver Klee voted on patch set 6 V +1 CR +1 07/25/23, 15:44

  25. core-ci voted on patch set 6 V +1 07/25/23, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44545

  26. Nikita Hovratov commented on patch set 6 07/25/23, 16:15

    Should we wait, until all other occurences are merged? Otherwise we need to remember to enable the deprecation logs afterwards.
  27. Thomas Hohn commented on patch set 6 07/25/23, 19:14

    Reply

    I agree :)
  28. Thomas Hohn uploaded patch set 7 CR +1 V +1 07/25/23, 19:15

  1. core-ci voted on patch set 7 V -1 07/25/23, 19:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44554

  2. Thomas Hohn uploaded patch set 8 V -1 07/25/23, 20:04

  3. core-ci voted on patch set 8 V +1 07/25/23, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44557

  4. Thomas Hohn uploaded patch set 9 V +1 10/26/23, 12:19

  5. core-ci voted on patch set 9 V +1 10/26/23, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48234

  6. Thomas Hohn commented on patch set 9 10/27/23, 12:13

    Reply

    Since we are nearly there - I'll close this "blocker"
  7. Thomas Hohn rebased onto patch set 10 V +1 12/05/23, 17:37

  8. core-ci voted on patch set 10 V +1 12/05/23, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50391

  9. Garvin Hicking commented on patch set 10 12/05/23, 18:02

    ClassNameMatcher.php:2354

    Is it by intention that an existing entry is renamed instead of adding a new one? And if it is contained in here, should the RST be tagged "fullyscanned" or partially scanned?
  10. Thomas Hohn commented on patch set 10 12/05/23, 18:17

    ClassNameMatcher.php:2354 Reply

    Looks like an rebase error - will fix
  11. Thomas Hohn uploaded patch set 11 V +1 12/05/23, 18:37

  12. core-ci voted on patch set 11 V +1 12/05/23, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50393

  13. Thomas Hohn commented on patch set 10 12/05/23, 18:49

    ClassNameMatcher.php:2354 Reply

    Done
  14. Christian Kuhn uploaded patch set 12 V +1 12/09/23, 16:35

  15. Christian Kuhn voted on patch set 12 CR +1 V +1 12/09/23, 16:37

  16. Oliver Klee voted on patch set 12 V +1 12/09/23, 16:40

  17. Oliver Klee voted on patch set 12 CR +1 12/09/23, 16:40

  18. core-ci voted on patch set 12 V -1 12/09/23, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50528

  19. Oliver Klee voted on patch set 12 V 0 12/09/23, 16:41

  20. Christian Kuhn uploaded patch set 13 CR +1 V +1 12/09/23, 16:41

  21. Christian Kuhn voted on patch set 13 CR +1 V +1 12/09/23, 16:42

  22. Oliver Klee voted on patch set 13 CR +1 V +1 12/09/23, 16:42

  23. core-ci voted on patch set 13 V +1 12/09/23, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50529

  24. Christian Kuhn voted on patch set 13 CR +2 V +2 12/09/23, 16:48

  25. Christian Kuhn merged patch set 14 12/09/23, 16:48