Review main Merged

79526[BUGFIX] Re-allow guzzlehttp/promises v1

Dennis Prinse CR +2 V +2 Easy +3 −3 updated 06/28/23, 07:25

Commit message

The update to only allow guzzlehttp/promises has been breaking to
external extensions and their dependencies. Only allowing
guzzlehttp/promises v2 caused projects to refuse updating TYPO3 from
v12.4.1 to v12.4.2

> composer require guzzlehttp/promises:"^1.5.2 || ^2.0"
> composer require --no-update guzzlehttp/promises:"^1.5.2 || ^2.0" \
 -d typo3/sysext/install/

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 912

  1. Dennis Prinse uploaded patch set 1 06/28/23, 06:33

  2. core-ci voted on patch set 1 V +1 06/28/23, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43057

  3. Oliver Hader commented on patch set 1 06/28/23, 06:45

    https://packagist.org/packages/guzzlehttp/guzzle#7.7.0 has a similar dependency `guzzlehttp/promises: ^1.5.3 || ^2.0` - thus, it looks okay. The previous change was merged to 11.5 as well...
  4. Nikita Hovratov updated the commit message in patch set 2 V +1 06/28/23, 06:55

  5. Nikita Hovratov updated the commit message in patch set 3 06/28/23, 07:01

  6. Nikita Hovratov commented on patch set 3 06/28/23, 07:03

    Reply

    Done
  7. core-ci voted on patch set 2 V +1 06/28/23, 07:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43058

  8. core-ci voted on patch set 3 V +1 06/28/23, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43059

  9. Oliver Hader voted on patch set 3 CR +1 06/28/23, 07:09

  10. Oliver Hader voted on patch set 3 V +1 06/28/23, 07:10

  11. Nikita Hovratov voted on patch set 3 V +2 CR +2 06/28/23, 07:25

  12. Nikita Hovratov merged patch set 4 06/28/23, 07:25