Review main Merged Breaking

79531[!!!][TASK] Enforce strict typing in UnableToLinkException

Thomas Hohn CR +2 V +2 Normal +34 −17 updated 07/21/23, 20:44

Commit message

Enforce that all methods and class variables are strictly typed in:
`\TYPO3\CMS\Frontend\Exception\UnableToLinkException`

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 1417

  1. Thomas Hohn uploaded patch set 1 06/28/23, 12:19

  2. core-ci voted on patch set 1 V +1 06/28/23, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43071

  3. Oliver Klee commented on patch set 1 06/28/23, 12:57

    UnableToLinkException.php:40

    Would it make sense to make $previous nullable as well (as the default value is null)?
  4. Thomas Hohn commented on patch set 1 06/28/23, 13:15

    UnableToLinkException.php:40 Reply

    So change it to ?\Throwable
  5. Thomas Hohn uploaded patch set 2 V +1 06/28/23, 13:27

  6. core-ci voted on patch set 2 V +1 06/28/23, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43072

  7. Thomas Hohn commented on patch set 2 06/28/23, 13:41

    UnableToLinkException.php:40 Reply

    Done
  8. Oliver Klee voted on patch set 2 V +1 CR +1 06/28/23, 13:51

  9. Jörg Bösche voted on patch set 2 CR +1 07/07/23, 12:03

  10. Oliver Klee commented on patch set 2 07/07/23, 12:09

    UnableToLinkException.php:28

    Maybe we can remove this `@var` annotation now. (It looks to be incomplete anyway.)

    UnableToLinkException.php:38

    Maybe we can drop the complete documentation block as it does not add anything substantial over the native type declarations. What do you think?
  11. Oliver Klee commented on patch set 2 07/15/23, 11:26

    UnableToLinkException.php:28 Reply

    Done

    UnableToLinkException.php:38 Reply

    Done
  12. Oliver Klee uploaded patch set 3 CR +1 V +1 07/15/23, 11:27

  13. Oliver Klee commented on patch set 2 V 0 CR 0 07/15/23, 11:28

    As this is a breaking change, we cannot backport this to 12.4 according to our policy.
  14. Oliver Klee voted on patch set 3 V +1 CR +1 07/15/23, 11:28

  15. core-ci voted on patch set 3 V +1 07/15/23, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44170

  16. Stefan Bürk voted on patch set 3 V +2 CR +2 07/21/23, 20:44

  17. Stefan Bürk merged patch set 4 07/21/23, 20:44