Review main Merged Breaking

79554[!!!][TASK] Remove fallback for CKEditor removePlugins

Thomas Hohn CR +2 V +2 Normal +53 −13 updated 09/26/23, 09:19

Commit message

Remove fallback for CKEditor removePlugins as a string.
It must now be an array.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 912

  1. Thomas Hohn uploaded patch set 1 06/29/23, 05:39

  2. core-ci voted on patch set 1 V +1 06/29/23, 05:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43094

  3. Thomas Hohn uploaded patch set 2 V +1 06/29/23, 05:56

  4. core-ci voted on patch set 2 V +1 06/29/23, 06:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43097

  5. Benjamin Franzke commented on patch set 2 CR -1 09/22/23, 06:19

    Breaking-101192-RemoveFallbackRemovePlugins.rst:27

    Breaking RSTs need a "Migration" section. Should be easy to add a before and after configuration example.
  6. Thomas Hohn uploaded patch set 3 CR -1 V +1 09/22/23, 06:44

  7. core-ci voted on patch set 3 V +1 09/22/23, 06:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47050

  8. Thomas Hohn commented on patch set 3 09/22/23, 06:56

    Breaking-101192-RemoveFallbackRemovePlugins.rst:27 Reply

    Done
  9. Andreas Nedbal voted on patch set 3 V +1 CR +1 09/25/23, 19:39

  10. Andreas Kienast voted on patch set 3 CR +1 09/26/23, 07:17

  11. Andreas Kienast voted on patch set 3 V +2 CR +2 09/26/23, 09:19

  12. Andreas Kienast merged patch set 4 09/26/23, 09:19