Review main Merged

79560[BUGFIX] Make list of webmount page ids really unique

Andreas Kienast CR +2 V +2 Easy +2 −1 updated 06/29/23, 15:11

Commit message

The fix for #100750 aimed to apply `array_unique()` to the array
containing page ids used as webmounts for the backend search.
Unfortunately, the call was done only for the storage in the runtime
cache with the side effect that still the full array with possible
duplications is returned on first invocation.

The affected `array_unique()` call is now extracted into a separate line
right before storing the resulting array to cache, which results in
returning the same, unified array.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Nikita Hovratov +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Nikita Hovratov +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 06/29/23, 14:16

  2. core-ci voted on patch set 1 V +1 06/29/23, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43115

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 06/29/23, 14:28

  4. Oliver Hader voted on patch set 1 V +1 CR +1 06/29/23, 15:02

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 06/29/23, 15:11

  6. Andreas Kienast merged patch set 2 06/29/23, 15:11