Review 12.4 Merged

79562[BUGFIX] Show source file and user agent in CSP backend module

Oliver Hader CR +2 V +2 Hard +224 −72 updated 06/29/23, 15:26

Commit message

The CSP backend module is not showing the optional source-file
of the reported violation. This information references to the
actual asset that caused the violation. In addition, visualizing
the user-agent helps to identifiy and reproduce possible flaws.

In case, `effective-directive` (preferred W3C property) is not
given, but `violated-directive` (legacy W3C property) is, that
value is taken - this still can happen in old browser versions.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 8

Review log 34

  1. Oliver Hader uploaded patch set 1 06/29/23, 15:10

  2. core-ci voted on patch set 1 V +1 06/29/23, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43120

  3. Oliver Hader voted on patch set 1 V +2 CR +2 06/29/23, 15:25

  4. Oliver Hader merged patch set 2 06/29/23, 15:26