Review 12.4 Merged

79566[TASK] SchemaMigrator is stateless

Christian Kuhn CR +2 V +2 Easy +17 −21 updated 06/30/23, 10:14

Commit message

Class SchemaMigrator has an unused property $schema.
Removing this property makes it more obvious
this service is stateless.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 06/30/23, 08:18

  2. core-ci voted on patch set 1 V +1 06/30/23, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43137

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 06/30/23, 10:14

  4. Christian Kuhn merged patch set 2 06/30/23, 10:14