79571[FEATURE] Introduce native enum InformationStatus
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Classes/Backend/ToolbarItems/SystemInformationToolbarItem.php17+42 −14
- typo3/sysext/backend/Classes/Toolbar/Enumeration/InformationStatus.php2+6 −0
- typo3/sysext/backend/Classes/Toolbar/InformationStatus.phpnew+49 −0
- typo3/sysext/belog/Classes/Controller/SystemInformationController.php+2 −2
- typo3/sysext/core/Documentation/Changelog/13.0/Deprecation-101174-InformationStatusClass.rst1new+61 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-101174-InformationStatus.rstnew+43 −0
- typo3/sysext/install/Classes/Controller/EnvironmentController.php3+3 −3
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php3+6 −0
- typo3/sysext/scheduler/Classes/SystemInformation/ToolbarItemProvider.php+4 −4
Review log 6587
Show 4762 earlier messages
-
Thomas Hohn uploaded patch set 1 06/30/23, 12:46
-
core-ci voted on patch set 1 V -1 06/30/23, 12:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43152
-
Thomas Hohn uploaded patch set 2
V -106/30/23, 13:21 -
core-ci voted on patch set 2 V +1 06/30/23, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43154
-
Oliver Klee commented on patch set 2 06/30/23, 14:10
-
Thomas Hohn uploaded patch set 3
V +106/30/23, 14:15 -
Thomas Hohn commented on patch set 3 06/30/23, 14:17
InformationStatus.php:3ReplyDone -
core-ci voted on patch set 3 V +1 06/30/23, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43155
-
Oliver Klee commented on patch set 3 06/30/23, 14:34
InformationStatus.php:34I propose we switch this to a native return type declaration. -
Thomas Hohn uploaded patch set 4
V +107/03/23, 04:42 -
Thomas Hohn commented on patch set 3 07/03/23, 04:42
InformationStatus.php:34ReplyDone -
core-ci voted on patch set 4 V +1 07/03/23, 04:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43200
-
Oliver Klee voted on patch set 4 V +1 07/03/23, 08:55
-
Thomas Hohn uploaded patch set 5
V +107/25/23, 19:12 -
core-ci voted on patch set 5 V +1 07/25/23, 19:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44552
-
Oliver Klee voted on patch set 5 V +1 07/27/23, 14:00
-
Anja Leichsenring uploaded patch set 6
V +108/02/23, 12:05 -
Anja Leichsenring voted on patch set 6 CR +1 08/02/23, 12:06
-
core-ci voted on patch set 6 V +1 08/02/23, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44884
-
Oliver Klee voted on patch set 6 V +1 08/02/23, 12:13
-
Thomas Hohn uploaded patch set 7
CR +1V +108/07/23, 04:54 -
core-ci voted on patch set 7 V +1 08/07/23, 05:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45162
-
Oliver Klee voted on patch set 7 V +1 08/07/23, 08:12
-
Jörg Bösche voted on patch set 7 CR +1 08/10/23, 13:01
-
Thomas Hohn uploaded patch set 8
CR +1V +109/22/23, 04:58 -
core-ci voted on patch set 8 V +1 09/22/23, 05:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47044
-
Benjamin Kott commented on patch set 8 09/22/23, 06:11
InformationStatus.php:26Do we really need to add the STATUS_ prefix to the enum? -
Benjamin Kott commented on patch set 8 09/22/23, 06:17
SystemInformationToolbarItem.php:53As seen here, the InformationStatus is used as Severity, don`t we need a more generic Severity Enum? -
Thomas Hohn commented on patch set 8 09/22/23, 06:58
SystemInformationToolbarItem.php:53ReplyWhat do you think Benni?InformationStatus.php:26ReplyMakes the migration easier ;-) -
Simon Schaufelberger commented on patch set 8 CR -1 09/22/23, 08:16
SystemInformationToolbarItem.php:77I prefer the format: "xxx has been deprecated in TYPO3 v13.0 and will be removed in v14.0"ClassNameMatcher.php:2360Why did you replace that? I think this should still be kept. -
Thomas Hohn commented on patch set 8 09/22/23, 08:40
ClassNameMatcher.php:2360ReplyI guess that must have been a merge conflict bummer from my side -
Thomas Hohn commented on patch set 8 09/22/23, 08:45
SystemInformationToolbarItem.php:77ReplyIn this case it's the type and not the method that is deprecated. So you would prefer: non-native enumeration TYPO3\CMS\Backend\Toolbar\Enumeration\InformationStatus in SystemInformationToolbarItem->addSystemMessage() been deprecated in TYPO3 v13.0 and will be removed in v14.0 ?? -
Thomas Hohn uploaded patch set 9
CR -1V +109/22/23, 10:35 -
Thomas Hohn commented on patch set 9 09/22/23, 10:38
SystemInformationToolbarItem.php:77ReplyDoneClassNameMatcher.php:2360ReplyDone -
core-ci voted on patch set 9 V +1 09/22/23, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47081
-
Simon Schaufelberger commented on patch set 9 09/22/23, 22:32
InformationStatus.php:732 spaces in message -
Thomas Hohn uploaded patch set 10
V +109/23/23, 05:43 -
Thomas Hohn commented on patch set 9 09/23/23, 05:43
InformationStatus.php:73ReplyDone -
core-ci voted on patch set 10 V +1 09/23/23, 05:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47111
-
Georg Ringer commented on patch set 10 09/25/23, 06:06
InformationStatus.php:26Replybut is uglier in the long run -
Andreas Kienast commented on patch set 10 09/25/23, 09:06
SystemInformationToolbarItem.php:53ReplyWe already have a generic severity enum: `TYPO3\CMS\Core\Type\ContextualFeedbackSeverity`.InformationStatus.php:26ReplyWouldn't do that either, it's duplicated information. Migration could be done via Rector anyway. -
Thomas Hohn uploaded patch set 11
V +110/12/23, 04:49 -
Thomas Hohn commented on patch set 11 10/12/23, 04:56
SystemInformationToolbarItem.php:53ReplyI would keep them apart for now since the one represents string and the other integer valuesInformationStatus.php:26ReplyDone -
Thomas Hohn commented on patch set 11 10/12/23, 04:56
SystemInformationToolbarItem.php:53ReplyDone -
core-ci voted on patch set 11 V +1 10/12/23, 04:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47700
-
Oliver Klee voted on patch set 11 V +1 10/12/23, 08:11
-
Thomas Hohn uploaded patch set 12
V +110/23/23, 08:39 -
core-ci voted on patch set 12 V +1 10/23/23, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48072
-
Oliver Klee voted on patch set 12 V +1 10/23/23, 08:57
-
Andreas Kienast commented on patch set 12 CR -1 10/26/23, 13:10
SystemInformationToolbarItem.php:65Since you added type declarations, having phpdoc doesn't make sense anymore.SystemInformationToolbarItem.php:73Thanks to introduced types, this type cast is now obsolete.SystemInformationToolbarItem.php:77I'd prefer using `InformationStatus::class` here.SystemInformationToolbarItem.php:93obsolete int cast -
Thomas Hohn commented on patch set 12 10/26/23, 13:32
SystemInformationToolbarItem.php:65ReplyDoneSystemInformationToolbarItem.php:73ReplyDoneSystemInformationToolbarItem.php:77ReplyLet's keep it as is please, there is no benefit in changing it - will be removed in v14SystemInformationToolbarItem.php:93ReplyDone -
Thomas Hohn uploaded patch set 13
CR -1V +110/26/23, 13:33 -
Thomas Hohn commented on patch set 13 10/26/23, 13:35
SystemInformationToolbarItem.php:77ReplyDone -
core-ci voted on patch set 13 V +1 10/26/23, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48237
-
Thomas Hohn uploaded patch set 14
V +110/27/23, 10:03 -
core-ci voted on patch set 14 V +1 10/27/23, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48283
-
Oliver Klee voted on patch set 14 V +1 10/27/23, 13:06
-
Oliver Klee voted on patch set 14 CR +1 10/27/23, 13:42
-
Nikita Hovratov uploaded patch set 15
CR +1V +110/27/23, 14:47 -
Oliver Klee voted on patch set 15 V +1 CR +1 10/27/23, 14:54
-
core-ci voted on patch set 15 V +1 10/27/23, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48297
-
Nikita Hovratov commented on patch set 15 10/27/23, 14:55
I think we should use the same strategy as with DuplicationBehavior and make this patch non-breaking. This has the advantage that we don't need to make a breaking change for this class two times in a row. On the other hand this class is rarely extended, so it wouldn't hurt to make it breaking. What do you think?
-
Thomas Hohn commented on patch set 15 10/28/23, 08:04
Reply
We can make it nonbreaking - will have a look at it next week -
Benni Mack voted on patch set 15 CR -1 10/30/23, 22:03
-
Benni Mack commented on patch set 15 10/30/23, 22:03
will have a closer look, no need to work on it Thomas -
Thomas Hohn uploaded patch set 16
CR +1V +111/09/23, 12:18 -
core-ci voted on patch set 16 V +1 11/09/23, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48751
-
Oli Bartsch uploaded patch set 17
V +112/05/23, 14:55 -
Oli Bartsch updated the commit message in patch set 18 12/05/23, 14:56
-
core-ci voted on patch set 18 V +1 12/05/23, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50382
-
core-ci voted on patch set 17 V +1 12/05/23, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50381
-
Benni Mack updated the commit message in patch set 19
V +112/05/23, 15:09 -
Benni Mack commented on patch set 19 12/05/23, 15:10
EnvironmentController.php:1061I do not understand this code -
core-ci voted on patch set 19 V +1 12/05/23, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50383
-
Thomas Hohn commented on patch set 19 12/05/23, 15:16
EnvironmentController.php:1061ReplySeems like an error - will look into it -
Thomas Hohn uploaded patch set 20
V +112/05/23, 15:26 -
core-ci voted on patch set 20 V -1 12/05/23, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50385
-
Thomas Hohn uploaded patch set 21
V -112/05/23, 16:02 -
Thomas Hohn updated the commit message in patch set 22 12/05/23, 16:03
-
core-ci voted on patch set 22 V +1 12/05/23, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50390
-
core-ci voted on patch set 21 V +1 12/05/23, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50389
-
Thomas Hohn commented on patch set 22 12/05/23, 16:10
EnvironmentController.php:1061ReplyDone now -
Thomas Hohn commented on patch set 22 12/05/23, 16:12
Reply
It should be non-breaking now @nikita.h@live.de -
Oli Bartsch voted on patch set 22 CR +1 V +1 12/05/23, 16:37
-
Benni Mack commented on patch set 22 CR +2 V +2 12/05/23, 17:10
thanks everybody involved! -
Benni Mack merged patch set 23 12/05/23, 17:10
-
Nikita Hovratov commented on patch set 23 12/05/23, 17:18
Deprecation-101174-InformationStatusClass.rst:21Unresolveddeprecated
InformationStatus.php:3