Review main Merged

79571[FEATURE] Introduce native enum InformationStatus

Thomas Hohn CR +2 V +2 Normal +216 −23 updated 12/05/23, 17:18

Commit message

This deprecates the InformationStatus class and adds the native
backed enum TYPO3\CMS\Backend\Toolbar\Enumeration\InformationStatus
as drop-in replacement.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 6587

Show 4762 earlier messages
  1. Thomas Hohn uploaded patch set 1 06/30/23, 12:46

  2. core-ci voted on patch set 1 V -1 06/30/23, 12:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43152

  3. Thomas Hohn uploaded patch set 2 V -1 06/30/23, 13:21

  4. core-ci voted on patch set 2 V +1 06/30/23, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43154

  5. Oliver Klee commented on patch set 2 06/30/23, 14:10

    InformationStatus.php:3

    Please let's make all new classes/enums strict when we create them.
  6. Thomas Hohn uploaded patch set 3 V +1 06/30/23, 14:15

  7. Thomas Hohn commented on patch set 3 06/30/23, 14:17

    InformationStatus.php:3 Reply

    Done
  8. core-ci voted on patch set 3 V +1 06/30/23, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43155

  9. Oliver Klee commented on patch set 3 06/30/23, 14:34

    InformationStatus.php:34

    I propose we switch this to a native return type declaration.
  10. Thomas Hohn uploaded patch set 4 V +1 07/03/23, 04:42

  11. Thomas Hohn commented on patch set 3 07/03/23, 04:42

    InformationStatus.php:34 Reply

    Done
  12. core-ci voted on patch set 4 V +1 07/03/23, 04:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43200

  13. Oliver Klee voted on patch set 4 V +1 07/03/23, 08:55

  14. Thomas Hohn uploaded patch set 5 V +1 07/25/23, 19:12

  15. core-ci voted on patch set 5 V +1 07/25/23, 19:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44552

  16. Oliver Klee voted on patch set 5 V +1 07/27/23, 14:00

  17. Anja Leichsenring uploaded patch set 6 V +1 08/02/23, 12:05

  18. Anja Leichsenring voted on patch set 6 CR +1 08/02/23, 12:06

  19. core-ci voted on patch set 6 V +1 08/02/23, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44884

  20. Oliver Klee voted on patch set 6 V +1 08/02/23, 12:13

  21. Thomas Hohn uploaded patch set 7 CR +1 V +1 08/07/23, 04:54

  22. core-ci voted on patch set 7 V +1 08/07/23, 05:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45162

  23. Oliver Klee voted on patch set 7 V +1 08/07/23, 08:12

  24. Jörg Bösche voted on patch set 7 CR +1 08/10/23, 13:01

  25. Thomas Hohn uploaded patch set 8 CR +1 V +1 09/22/23, 04:58

  26. core-ci voted on patch set 8 V +1 09/22/23, 05:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47044

  27. Benjamin Kott commented on patch set 8 09/22/23, 06:11

    InformationStatus.php:26

    Do we really need to add the STATUS_ prefix to the enum?
  28. Benjamin Kott commented on patch set 8 09/22/23, 06:17

    SystemInformationToolbarItem.php:53

    As seen here, the InformationStatus is used as Severity, don`t we need a more generic Severity Enum?
  29. Thomas Hohn commented on patch set 8 09/22/23, 06:58

    SystemInformationToolbarItem.php:53 Reply

    What do you think Benni?

    InformationStatus.php:26 Reply

    Makes the migration easier ;-)
  30. Simon Schaufelberger commented on patch set 8 CR -1 09/22/23, 08:16

    SystemInformationToolbarItem.php:77

    I prefer the format: "xxx has been deprecated in TYPO3 v13.0 and will be removed in v14.0"

    ClassNameMatcher.php:2360

    Why did you replace that? I think this should still be kept.
  31. Thomas Hohn commented on patch set 8 09/22/23, 08:40

    ClassNameMatcher.php:2360 Reply

    I guess that must have been a merge conflict bummer from my side
  32. Thomas Hohn commented on patch set 8 09/22/23, 08:45

    SystemInformationToolbarItem.php:77 Reply

    In this case it's the type and not the method that is deprecated. So you would prefer: non-native enumeration TYPO3\CMS\Backend\Toolbar\Enumeration\InformationStatus in SystemInformationToolbarItem->addSystemMessage() been deprecated in TYPO3 v13.0 and will be removed in v14.0 ??
  33. Thomas Hohn uploaded patch set 9 CR -1 V +1 09/22/23, 10:35

  34. Thomas Hohn commented on patch set 9 09/22/23, 10:38

    SystemInformationToolbarItem.php:77 Reply

    Done

    ClassNameMatcher.php:2360 Reply

    Done
  35. core-ci voted on patch set 9 V +1 09/22/23, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47081

  36. Simon Schaufelberger commented on patch set 9 09/22/23, 22:32

    InformationStatus.php:73

    2 spaces in message
  37. Thomas Hohn uploaded patch set 10 V +1 09/23/23, 05:43

  38. Thomas Hohn commented on patch set 9 09/23/23, 05:43

    InformationStatus.php:73 Reply

    Done
  39. core-ci voted on patch set 10 V +1 09/23/23, 05:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47111

  40. Georg Ringer commented on patch set 10 09/25/23, 06:06

    InformationStatus.php:26 Reply

    but is uglier in the long run
  41. Andreas Kienast commented on patch set 10 09/25/23, 09:06

    SystemInformationToolbarItem.php:53 Reply

    We already have a generic severity enum: `TYPO3\CMS\Core\Type\ContextualFeedbackSeverity`.

    InformationStatus.php:26 Reply

    Wouldn't do that either, it's duplicated information. Migration could be done via Rector anyway.
  42. Thomas Hohn uploaded patch set 11 V +1 10/12/23, 04:49

  43. Thomas Hohn commented on patch set 11 10/12/23, 04:56

    SystemInformationToolbarItem.php:53 Reply

    I would keep them apart for now since the one represents string and the other integer values

    InformationStatus.php:26 Reply

    Done
  44. Thomas Hohn commented on patch set 11 10/12/23, 04:56

    SystemInformationToolbarItem.php:53 Reply

    Done
  45. core-ci voted on patch set 11 V +1 10/12/23, 04:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47700

  46. Oliver Klee voted on patch set 11 V +1 10/12/23, 08:11

  47. Thomas Hohn uploaded patch set 12 V +1 10/23/23, 08:39

  48. core-ci voted on patch set 12 V +1 10/23/23, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48072

  49. Oliver Klee voted on patch set 12 V +1 10/23/23, 08:57

  50. Andreas Kienast commented on patch set 12 CR -1 10/26/23, 13:10

    SystemInformationToolbarItem.php:65

    Since you added type declarations, having phpdoc doesn't make sense anymore.

    SystemInformationToolbarItem.php:73

    Thanks to introduced types, this type cast is now obsolete.

    SystemInformationToolbarItem.php:77

    I'd prefer using `InformationStatus::class` here.

    SystemInformationToolbarItem.php:93

    obsolete int cast
  51. Thomas Hohn commented on patch set 12 10/26/23, 13:32

    SystemInformationToolbarItem.php:65 Reply

    Done

    SystemInformationToolbarItem.php:73 Reply

    Done

    SystemInformationToolbarItem.php:77 Reply

    Let's keep it as is please, there is no benefit in changing it - will be removed in v14

    SystemInformationToolbarItem.php:93 Reply

    Done
  52. Thomas Hohn uploaded patch set 13 CR -1 V +1 10/26/23, 13:33

  53. Thomas Hohn commented on patch set 13 10/26/23, 13:35

    SystemInformationToolbarItem.php:77 Reply

    Done
  54. core-ci voted on patch set 13 V +1 10/26/23, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48237

  55. Thomas Hohn uploaded patch set 14 V +1 10/27/23, 10:03

  56. core-ci voted on patch set 14 V +1 10/27/23, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48283

  57. Oliver Klee voted on patch set 14 V +1 10/27/23, 13:06

  58. Oliver Klee voted on patch set 14 CR +1 10/27/23, 13:42

  59. Nikita Hovratov uploaded patch set 15 CR +1 V +1 10/27/23, 14:47

  60. Oliver Klee voted on patch set 15 V +1 CR +1 10/27/23, 14:54

  61. core-ci voted on patch set 15 V +1 10/27/23, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48297

  62. Nikita Hovratov commented on patch set 15 10/27/23, 14:55

    I think we should use the same strategy as with DuplicationBehavior and make this patch non-breaking. This has the advantage that we don't need to make a breaking change for this class two times in a row. On the other hand this class is rarely extended, so it wouldn't hurt to make it breaking. What do you think?
  1. Thomas Hohn commented on patch set 15 10/28/23, 08:04

    Reply

    We can make it nonbreaking - will have a look at it next week
  2. Benni Mack voted on patch set 15 CR -1 10/30/23, 22:03

  3. Benni Mack commented on patch set 15 10/30/23, 22:03

    will have a closer look, no need to work on it Thomas
  4. Thomas Hohn uploaded patch set 16 CR +1 V +1 11/09/23, 12:18

  5. core-ci voted on patch set 16 V +1 11/09/23, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48751

  6. Oli Bartsch uploaded patch set 17 V +1 12/05/23, 14:55

  7. Oli Bartsch updated the commit message in patch set 18 12/05/23, 14:56

  8. core-ci voted on patch set 18 V +1 12/05/23, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50382

  9. core-ci voted on patch set 17 V +1 12/05/23, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50381

  10. Benni Mack updated the commit message in patch set 19 V +1 12/05/23, 15:09

  11. Benni Mack commented on patch set 19 12/05/23, 15:10

    EnvironmentController.php:1061

    I do not understand this code
  12. core-ci voted on patch set 19 V +1 12/05/23, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50383

  13. Thomas Hohn commented on patch set 19 12/05/23, 15:16

    EnvironmentController.php:1061 Reply

    Seems like an error - will look into it
  14. Thomas Hohn uploaded patch set 20 V +1 12/05/23, 15:26

  15. core-ci voted on patch set 20 V -1 12/05/23, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50385

  16. Thomas Hohn uploaded patch set 21 V -1 12/05/23, 16:02

  17. Thomas Hohn updated the commit message in patch set 22 12/05/23, 16:03

  18. core-ci voted on patch set 22 V +1 12/05/23, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50390

  19. core-ci voted on patch set 21 V +1 12/05/23, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50389

  20. Thomas Hohn commented on patch set 22 12/05/23, 16:10

    EnvironmentController.php:1061 Reply

    Done now
  21. Thomas Hohn commented on patch set 22 12/05/23, 16:12

    Reply

    It should be non-breaking now @nikita.h@live.de
  22. Oli Bartsch voted on patch set 22 CR +1 V +1 12/05/23, 16:37

  23. Benni Mack commented on patch set 22 CR +2 V +2 12/05/23, 17:10

    thanks everybody involved!
  24. Benni Mack merged patch set 23 12/05/23, 17:10

  25. Nikita Hovratov commented on patch set 23 12/05/23, 17:18

    Deprecation-101174-InformationStatusClass.rst:21 Unresolved

    deprecated