79572[TASK] Clean up usages of ContentObjectRenderer request attribute
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- Jörg Bösche +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1011
-
Helmut Hummel uploaded patch set 1 06/30/23, 15:31
-
core-ci voted on patch set 1 V +1 06/30/23, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43157
-
Oliver Klee voted on patch set 1 V +1 06/30/23, 15:57
-
Jörg Bösche voted on patch set 1 CR +1 08/25/23, 14:09
-
Nikita Hovratov voted on patch set 1 V +1 CR +1 09/07/23, 19:24
-
Stefan Bürk voted on patch set 1 V +2 CR +2 09/07/23, 19:59
-
Stefan Bürk voted on patch set 1 V +1 CR +1 09/07/23, 20:05
-
Stefan Bürk voted on patch set 1 V +2 CR +2 09/07/23, 21:07
-
Stefan Bürk merged patch set 2 09/07/23, 21:07
-
Alexander Schnitzler commented on patch set 2 08/21/25, 13:00
-
Alexander Schnitzler commented on patch set 2 08/21/25, 13:26
UriBuilder.php:520Reply UnresolvedI am just seeing that `ContentObjectRenderer::createLink()` potentially also returns an empty string. That however, has never been a problem in the past with a proper link configuration. Still, I'd opt for using the LinkFactory here directly in the future. This also needs a ContentObjectRenderer but we would then not suppress exceptions that stem from a possibly invalid configuration.
UriBuilder.php:520