Review main Merged

79574[TASK] Remove fallback in SiteConfiguration constructor

Christoph Lehmann CR +2 V +2 Easy +6 −17 updated 07/03/23, 14:48

Commit message

Its todo is solved. This also introduces constructor property promotion.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Christoph Lehmann uploaded patch set 1 06/30/23, 19:33

  2. core-ci voted on patch set 1 V +1 06/30/23, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43165

  3. Christoph Lehmann updated the commit message in patch set 2 V +1 06/30/23, 19:45

  4. Oliver Klee voted on patch set 2 CR +1 06/30/23, 19:50

  5. core-ci voted on patch set 2 V +1 06/30/23, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43166

  6. Benni Mack voted on patch set 2 V +1 CR +1 07/03/23, 13:08

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 07/03/23, 14:48

  8. Stefan Bürk merged patch set 3 07/03/23, 14:48