Review main Merged

79586[BUGFIX] Fetch pages in different language when in free mode

Benni Mack CR +2 V +2 Normal +209 −0 updated 07/13/23, 08:30

Commit message

The special case for "pages" is that there is always
a record in sys_language_uid=0 and that the pages
in the default language are usually used for linking
and pointing to a page.

For this reason, it is important to actually fetch
the page in language variant "5" for example to also
fetch the page.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Susi Moog +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1115

  1. Benni Mack uploaded patch set 1 07/03/23, 10:42

  2. core-ci voted on patch set 1 V +1 07/03/23, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43212

  3. Benni Mack commented on patch set 1 CR -1 07/03/23, 15:34

    will add some more tests.
  4. Benni Mack uploaded patch set 2 CR -1 V +1 07/06/23, 20:26

  5. core-ci voted on patch set 2 V -1 07/06/23, 20:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43831

  6. Benni Mack rebased onto patch set 3 V -1 07/07/23, 08:05

  7. Oliver Klee commented on patch set 3 07/07/23, 08:08

    Nice tests! <3
  8. core-ci voted on patch set 3 V +1 07/07/23, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43861

  9. Oli Bartsch commented on patch set 4 V +1 07/07/23, 08:25

    Published edit on patch set 3.
  10. Oliver Klee voted on patch set 4 V +1 07/07/23, 08:35

  11. core-ci voted on patch set 4 V +1 07/07/23, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43867

  12. Susi Moog voted on patch set 4 V +1 CR +1 07/07/23, 09:50

  13. Stefan Bürk voted on patch set 4 V +1 CR +1 07/13/23, 07:28

  14. Stefan Bürk voted on patch set 4 V +2 CR +2 07/13/23, 07:51

  15. Stefan Bürk merged patch set 5 07/13/23, 08:30