Review main Merged

79589[BUGFIX] Loosen types for PSR-7 message implementation

Benni Mack CR +2 V +2 Easy +18 −8 updated 07/06/23, 04:09

Commit message

This change allows user-lang code when using
TYPO3's PSR-7 implementation to also use integers
and floats for header values.

This change popped up in PHP 8.0 environments.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1317

  1. Benni Mack uploaded patch set 1 07/03/23, 11:41

  2. Oliver Klee commented on patch set 1 07/03/23, 11:48

    Can we cover this with a test?
  3. core-ci voted on patch set 1 V -1 07/03/23, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43221

  4. Oliver Klee commented on patch set 1 07/03/23, 11:48

    Reply

    (marking as unresolved)
  5. Benni Mack uploaded patch set 2 V -1 07/03/23, 13:05

  6. Benni Mack commented on patch set 1 07/03/23, 13:05

    Reply

    already done. adapted tests now
  7. core-ci voted on patch set 2 V -1 07/03/23, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43232

  8. Benni Mack uploaded patch set 3 V -1 07/03/23, 14:29

  9. Susi Moog voted on patch set 3 CR +1 07/03/23, 14:32

  10. Oliver Klee voted on patch set 3 CR +1 07/03/23, 14:35

  11. core-ci voted on patch set 3 V +1 07/03/23, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43240

  12. Frank Nägler uploaded patch set 4 CR +1 V +1 07/05/23, 21:09

  13. Frank Nägler voted on patch set 4 V +1 CR +1 07/05/23, 21:10

  14. core-ci voted on patch set 4 V +1 07/05/23, 21:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43641

  15. Oliver Klee voted on patch set 4 V +1 CR +1 07/05/23, 23:10

  16. Georg Ringer voted on patch set 4 V +2 CR +2 07/06/23, 04:09

  17. Georg Ringer merged patch set 5 07/06/23, 04:09