Review main Merged

79592[BUGFIX] Set locale for FormatSize

Susi Moog CR +2 V +2 Easy +7 −0 updated 07/03/23, 13:16

Commit message

As LC_NUMERIC is not set via Locales::setLocale
because conflicts on float calculation may occur,
we have to manually set LC_NUMERIC in places where
we need the locale aware numeric functionality.

In the core this is only formatSize - which missed
the LC_NUMERIC handling since the switch to
SiteConfiguration. With this patch, the handling is
reintroduced by using the locale set by setLocale for
LC_MONETARY to temporarily set LC_NUMERIC in formatSize.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 711

  1. Susi Moog uploaded patch set 1 07/03/23, 09:52

  2. core-ci voted on patch set 1 V -1 07/03/23, 10:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43208

  3. Torben Hansen uploaded patch set 2 V -1 07/03/23, 10:35

  4. core-ci voted on patch set 2 V -1 07/03/23, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43211

  5. Torben Hansen uploaded patch set 3 V -1 07/03/23, 10:53

  6. core-ci voted on patch set 3 V -1 07/03/23, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43215

  7. Torben Hansen uploaded patch set 4 V -1 07/03/23, 12:18

  8. core-ci voted on patch set 4 V +1 07/03/23, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43224

  9. Torben Hansen voted on patch set 4 V +1 CR +1 07/03/23, 13:06

  10. Benni Mack voted on patch set 4 V +2 CR +2 07/03/23, 13:16

  11. Benni Mack merged patch set 5 07/03/23, 13:16