Review main Merged

79593[BUGFIX] Add better read-only settings.php handling to SilentUpgrade

Susi Moog CR +2 V +2 Normal +107 −5 updated 07/21/23, 20:59

Commit message

The SilentUpgrade handles changes "under the hood" by migrating
old to new settings. If the settings.php is not writable, these
changes fail with an exception. As we cannot predict which side-
effects non-execution may have, we cannot allow further usage of
the install tool before those changes are done. We are now giving
the user a better error message and the option to run silent
upgrade with the normal CLI upgrade command.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 8