79615[BUGFIX] Enable additional attributes for Media ViewHelper
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Jochen Roth +1
- Frank Nägler +1
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Jochen Roth +1
- Frank Nägler +1
- Susi Moog +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/core/Classes/Resource/Rendering/VideoTagRenderer.php+8 −2
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VideoTagRendererTest.php+15 −0
- typo3/sysext/fluid/Classes/ViewHelpers/MediaViewHelper.php+15 −8
- typo3/sysext/fluid/Tests/Functional/Fixtures/ViewHelpers/Link/FileViewHelper/Folders/fileadmin/user_upload/example.mp4newbinary
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/MediaViewHelperTest.phpnew+65 −0
Review log 1015
-
Benni Mack uploaded patch set 1 07/03/23, 13:41
-
core-ci voted on patch set 1 V +1 07/03/23, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43235
-
Benni Mack uploaded patch set 2
V +107/03/23, 16:59 -
Benni Mack updated the commit message in patch set 3 07/03/23, 16:59
-
Benni Mack uploaded patch set 4 07/03/23, 17:04
-
Benni Mack updated the commit message in patch set 5 07/03/23, 17:05
-
core-ci voted on patch set 3 V +1 07/03/23, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43267
-
core-ci voted on patch set 2 V +1 07/03/23, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43266
-
core-ci voted on patch set 5 V +1 07/03/23, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43269
-
core-ci voted on patch set 4 V +1 07/03/23, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43268
-
Jochen Roth voted on patch set 5 V +1 CR +1 07/03/23, 18:08
-
Susi Moog voted on patch set 5 V +1 CR +1 07/03/23, 19:00
-
Frank Nägler voted on patch set 5 V +1 CR +1 07/03/23, 19:43
-
Benni Mack voted on patch set 5 V +2 CR +2 07/03/23, 19:52
-
Benni Mack merged patch set 6 07/03/23, 19:53