Review main Merged

79615[BUGFIX] Enable additional attributes for Media ViewHelper

Benni Mack CR +2 V +2 Normal +103 −10 updated 07/03/23, 19:53

Commit message

This change also adds some basic tests for MediaViewHelper

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Frank Nägler +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Frank Nägler +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1015

  1. Benni Mack uploaded patch set 1 07/03/23, 13:41

  2. core-ci voted on patch set 1 V +1 07/03/23, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43235

  3. Benni Mack uploaded patch set 2 V +1 07/03/23, 16:59

  4. Benni Mack updated the commit message in patch set 3 07/03/23, 16:59

  5. Benni Mack uploaded patch set 4 07/03/23, 17:04

  6. Benni Mack updated the commit message in patch set 5 07/03/23, 17:05

  7. core-ci voted on patch set 3 V +1 07/03/23, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43267

  8. core-ci voted on patch set 2 V +1 07/03/23, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43266

  9. core-ci voted on patch set 5 V +1 07/03/23, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43269

  10. core-ci voted on patch set 4 V +1 07/03/23, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43268

  11. Jochen Roth voted on patch set 5 V +1 CR +1 07/03/23, 18:08

  12. Susi Moog voted on patch set 5 V +1 CR +1 07/03/23, 19:00

  13. Frank Nägler voted on patch set 5 V +1 CR +1 07/03/23, 19:43

  14. Benni Mack voted on patch set 5 V +2 CR +2 07/03/23, 19:52

  15. Benni Mack merged patch set 6 07/03/23, 19:53