Review main Abandoned

79618[BUGFIX] Get fresh button instances in "Analyze Database Structure"

Andreas Kienast CR 0 V 0 Easy +3 −4 updated 02/06/24, 10:47

Commit message

Since TYPO3 v12, modal windows are based on Lit components. This
introduced an issue with the buttons in the
"Analyze Database Structure" modal window in the Install Tool.
Upon entering the `analyze()` method, the buttons were fetched and
stored in an inline variable for easier access. Since the modal content
changes during loading operations, the whole modal is re-rendered, which
results in lost references to the buttons.

To fix the issue, the buttons are now always queried when it's attempted
to interact with them to be able to set the disabled state properly.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 45

  1. Andreas Kienast uploaded patch set 1 07/03/23, 15:02

  2. core-ci voted on patch set 1 V +1 07/03/23, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43246

  3. Annett Jähnichen voted on patch set 1 V +1 CR +1 07/03/23, 15:10

  4. Oli Bartsch commented on patch set 1 V -1 07/03/23, 15:57

    Unresolved

    The button is now disabled but is not enabled on selecting field changes
  5. Andreas Kienast abandoned the change 02/06/24, 10:47