79621[BUGFIX] Make parallel execution checkbox in scheduler working
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jasmina Ließmann +1
- Jochen Roth +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jasmina Ließmann +1
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 4
Review log 911
-
Oli Bartsch uploaded patch set 1 07/03/23, 17:21
-
core-ci voted on patch set 1 V +1 07/03/23, 17:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43272
-
Jasmina Ließmann commented on patch set 1 07/03/23, 17:36
Works when saving, thanks! Maybe another issue can be fixed here as well? When you activate the checkbox and then close and reopen the task, the checkbox is inactive again. Same behaviour in v12.4 and main. -
Oli Bartsch uploaded patch set 2
V +107/03/23, 18:53 -
Oli Bartsch commented on patch set 2 07/03/23, 18:54
Reply
This is actually not a bug but intended. I assume you tried to activate the parallel execution on a "single execution" task, right? In this case, multiple is always set to "false", see https://github.com/TYPO3/typo3/blob/main/typo3/sysext/scheduler/Classes/Task/AbstractTask.php#L316 I therefore updated the patch to also hide the checkbox for single execution tasks, like it's done for the endtime and frequency fields already. -
core-ci voted on patch set 2 V +1 07/03/23, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43282
-
Jasmina Ließmann voted on patch set 2 V +1 CR +1 07/03/23, 19:07
-
Jochen Roth voted on patch set 2 V +1 CR +1 07/03/23, 19:35
-
Christian Kuhn voted on patch set 2 CR +1 07/04/23, 07:59
-
Oli Bartsch voted on patch set 2 V +2 CR +2 07/04/23, 08:40
-
Oli Bartsch merged patch set 3 07/04/23, 08:40