Review main Merged

79654[BUGFIX] Add read_only to cache identifier for file mounts

Susi Moog CR +2 V +2 Easy +26 −9 updated 07/05/23, 12:08

Commit message

The cache identifier for file mounts only consisted of storage id
and path. In rare cases (with same name file mounts with different
read-only settings) this lead to rendering an arbitrary folder instead
of the mount with the "higher" access rights.

The read_only field is now taken into account when generating the
runtime cache identifier.

The file module already takes care of using the write file mount if
both read-only and not read-only exist.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 79

  1. Susi Moog uploaded patch set 1 07/04/23, 18:27

  2. core-ci voted on patch set 1 V +1 07/04/23, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43418

  3. Benni Mack commented on patch set 1 07/04/23, 19:11

    Can we cover this with a test?
  4. Susi Moog uploaded patch set 2 V +1 07/05/23, 07:26

  5. Susi Moog commented on patch set 2 07/05/23, 07:27

    Reply

    yes.
  6. core-ci voted on patch set 2 V +1 07/05/23, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43463

  7. Benni Mack voted on patch set 2 V +1 CR +1 07/05/23, 11:49

  8. Stefan Bürk voted on patch set 2 V +2 CR +2 07/05/23, 12:08

  9. Stefan Bürk merged patch set 3 07/05/23, 12:08