Review main Merged

79655[BUGFIX] Check default language for preview requirements

Susi Moog CR +2 V +2 Easy +13 −4 updated 07/06/23, 11:41

Commit message

When previewing a translated page that is enabled which has
a parent (default lang) page that is hidden, users got a 403
error, because the preview flag was not set (as the page itself
was not hidden).

Change the check to always check both the default language and
the overlay for setting the preview flag.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 57

  1. Susi Moog uploaded patch set 1 07/06/23, 06:52

  2. core-ci voted on patch set 1 V +1 07/06/23, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43657

  3. Benni Mack uploaded patch set 2 V +1 07/06/23, 10:18

  4. Benni Mack voted on patch set 2 V +1 CR +1 07/06/23, 10:18

  5. core-ci voted on patch set 2 V +1 07/06/23, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43682

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 07/06/23, 11:41

  7. Andreas Kienast merged patch set 3 07/06/23, 11:41