Review 12.4 Merged

79672[BUGFIX] Consider more TMENU a-tag related config for runtime cache

Nikita Hovratov CR +2 V +2 Easy +13 −1 updated 07/04/23, 07:31

Commit message

Since the swap to LinkResult, the ATagParams and some more attributes
are cached independent of different configuration. This is now fixed by
adding the following configuration options to the md5 hash:

- TMENUITEM: ATagParams
- TMENUITEM: additionalParams
- TMENU: addParams
- TMENU: target

Note: Doing this weakens the usefulness of the runtime cache again
(especially for old-school TypoScript based menus). Another option would
be to add the attributes after the LinkResult generation (how it was
done before), but this would bypass possible Event manipulation.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Nikita Hovratov commented on patch set 1 07/04/23, 07:16

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/04/23, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43334

  3. Nikita Hovratov voted on patch set 1 V +2 CR +2 07/04/23, 07:31

  4. Nikita Hovratov merged patch set 2 07/04/23, 07:31