Review main Merged

79694[TASK] Use callout component for slug hints

Andreas Nedbal CR +2 V +2 Easy +10 −2 updated 07/04/23, 17:47

Commit message

The hint when changing a slug previously was a
combination of utility classes and with color changes
in a recent Bootstrap version, it became barely readable.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Oli Bartsch +1
    • Annett Jähnichen +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Oli Bartsch +1
    • Annett Jähnichen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1216

  1. Andreas Nedbal uploaded patch set 1 07/04/23, 09:31

  2. Andreas Nedbal updated the commit message in patch set 2 07/04/23, 09:33

  3. core-ci voted on patch set 1 V +1 07/04/23, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43350

  4. core-ci voted on patch set 2 V +1 07/04/23, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43351

  5. Annett Jähnichen voted on patch set 2 V +1 CR +1 07/04/23, 09:47

  6. Thomas Hohn voted on patch set 2 CR +1 07/04/23, 09:55

  7. Benni Mack voted on patch set 2 V +1 CR +1 07/04/23, 16:00

  8. Oli Bartsch commented on patch set 2 CR -1 07/04/23, 16:50

    "media-body" wrapper can be skipped
  9. Andreas Nedbal uploaded patch set 3 CR +1 V +1 07/04/23, 16:54

  10. core-ci voted on patch set 3 V +1 07/04/23, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43407

  11. Oli Bartsch uploaded patch set 4 V +1 07/04/23, 17:10

  12. Oli Bartsch voted on patch set 4 V +1 CR +1 07/04/23, 17:10

  13. core-ci voted on patch set 4 V +1 07/04/23, 17:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43408

  14. Annett Jähnichen voted on patch set 4 V +1 CR +1 07/04/23, 17:43

  15. Andreas Nedbal voted on patch set 4 V +2 CR +2 07/04/23, 17:47

  16. Andreas Nedbal merged patch set 5 07/04/23, 17:47