Review main Merged

79699[BUGFIX] Streamline new record button titles in recordlist

Annett Jähnichen CR +2 V +2 Easy +9 −5 updated 07/04/23, 20:15

Commit message

To streamline the titles a specific language label is added for
the recordlist, which uses the TCA table title configuration of
every table. This leads to the fact that every new record button
now includes the specific table title analogous to recordlist-heading-title.

Additonally, this also unifies the modal header of the new
content element wizard, which previously was triggered using
different labels through the backend.

Review

  • Code review CR +2 Done
    • Annett Jähnichen +2
    • Oli Bartsch +1
    • Torben Hansen +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Annett Jähnichen +2
    • Oli Bartsch +1
    • Torben Hansen +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1214

  1. Annett Jähnichen uploaded patch set 1 07/04/23, 13:33

  2. Lina Wolf commented on patch set 1 07/04/23, 13:54

    Wizard.html:14

    Why do you change the header level here? Is this part of unifying the header levels? In Accessibility there are rules about properly nesting the headers.
  3. core-ci voted on patch set 1 V +1 07/04/23, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43383

  4. Annett Jähnichen commented on patch set 1 07/04/23, 16:44

    Wizard.html:14 Reply

    The headline in the DOM before that is an h4, then I think it should be followed by an h5.
  5. Lina Wolf commented on patch set 1 07/04/23, 16:48

    Wizard.html:14 Reply

    Ack
  6. Andreas Nedbal voted on patch set 1 V +1 CR +1 07/04/23, 17:09

  7. Oli Bartsch commented on patch set 1 07/04/23, 17:55

    locallang_layout.xlf:151

    Why do we change this label? I think we should at least not remove the action ("create") here to still be consistent with the other labels.

    locallang_mod_web_list.xlf:55

    Indentation looks wrong here.
  8. Oli Bartsch uploaded patch set 2 CR +1 V +1 07/04/23, 18:15

  9. Oli Bartsch commented on patch set 2 V +1 CR +1 07/04/23, 18:15

    locallang_layout.xlf:151 Reply

    Ack

    locallang_mod_web_list.xlf:55 Reply

    Done
  10. core-ci voted on patch set 2 V +1 07/04/23, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43416

  11. Torben Hansen voted on patch set 2 V +1 CR +1 07/04/23, 19:02

  12. Stefan Bürk voted on patch set 2 V +1 CR +1 07/04/23, 20:02

  13. Annett Jähnichen voted on patch set 2 V +2 CR +2 07/04/23, 20:15

  14. Annett Jähnichen merged patch set 3 07/04/23, 20:15