79703[TASK] Unify layout of SelectCheckBox group headers
Commit message
Review
-
Code review CR +2 Done
- Andreas Nedbal +2
- Jasmina Ließmann +1
- Michael Telgkamp +1
-
Verified V +2 Done
- Andreas Nedbal +2
- Jasmina Ließmann +1
- Michael Telgkamp +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/Sass/component/_panel.scss+9 −0
- Build/Sources/TypeScript/backend/form-engine/element/select-check-box-element.tsnew+54 −0
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php6+15 −5
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-check-box-element.jsnew+13 −0
Review log 2839
Show 1014 earlier messages
-
Andreas Nedbal uploaded patch set 1 07/04/23, 16:41
-
core-ci voted on patch set 1 V +1 07/04/23, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43406
-
Annett Jähnichen voted on patch set 1 V +1 07/04/23, 18:22
-
Sybille Peters commented on patch set 1 V +1 07/06/23, 10:03
I checked the "Explicitly allow field values" section in the BE groups. With the patch it now has an "expand" icon (v). Looks good. (will post my screenshots to issue) -
Oliver Hader commented on patch set 1 09/19/23, 17:39
SelectCheckBoxElement.php:174`htmlspecialchars` should wrap the `sprintf` - otherwise `$group['header']['title']` would not be covered -
Andreas Nedbal rebased onto patch set 2
V +106/10/24, 13:57The following files contain Git conflicts: * typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php -
core-ci voted on patch set 2 V -1 06/10/24, 14:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59014
-
Sybille Peters wrote 06/10/24, 14:21
Removed reviewer Sybille Peters. -
Andreas Nedbal uploaded patch set 3
V -106/11/24, 07:45 -
core-ci voted on patch set 3 V -1 06/11/24, 08:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59119
-
Andreas Nedbal uploaded patch set 4
V -106/11/24, 09:57 -
core-ci voted on patch set 4 V -1 06/11/24, 10:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59156
-
Andreas Nedbal uploaded patch set 5
V -106/11/24, 11:06 -
Andreas Nedbal uploaded patch set 6 06/11/24, 11:08
-
core-ci voted on patch set 5 V -1 06/11/24, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59166
-
core-ci voted on patch set 6 V -1 06/11/24, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59167
-
Andreas Nedbal uploaded patch set 7
V -106/11/24, 11:51 -
core-ci voted on patch set 7 V +1 06/11/24, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59174
-
Andreas Nedbal marked it ready for review 06/11/24, 12:01
-
Michael Telgkamp commented on patch set 7 CR +1 V +1 06/11/24, 13:17
Thank you for the patch and the improvement of the accessibility by changing the element to a button.SelectCheckBoxElement.php:174ReplyDone -
Jasmina Ließmann voted on patch set 7 CR +1 V +1 06/11/24, 14:04
-
Andreas Nedbal rebased onto patch set 8
CR +1V +106/12/24, 16:39The following files contain Git conflicts: * Build/Sources/TypeScript/backend/form-engine/element/select-check-box-element.ts * typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-check-box-element.js -
core-ci voted on patch set 8 V -1 06/12/24, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59355
-
Michael Telgkamp uploaded patch set 9
V -106/12/24, 17:34 -
core-ci voted on patch set 9 V +1 06/12/24, 17:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59359
-
Andreas Nedbal marked it ready for review 06/12/24, 17:43
-
Michael Telgkamp voted on patch set 9 CR +1 V +1 06/12/24, 17:44
-
Andreas Nedbal commented on patch set 9 V -1 06/12/24, 19:07
on it -
Andreas Nedbal uploaded patch set 10
CR +1V +106/12/24, 19:28 -
core-ci voted on patch set 10 V +1 06/12/24, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59364
-
Jasmina Ließmann commented on patch set 10 06/12/24, 19:34
SelectCheckBoxElement.php:175Looks like it $title is unused and can be removed. The language key is also not available anymore. -
Jasmina Ließmann commented on patch set 10 06/12/24, 19:36
SelectCheckBoxElement.php:184This div is never closed. -
Andreas Nedbal uploaded patch set 11
V +106/12/24, 19:41 -
Andreas Nedbal commented on patch set 11 06/12/24, 19:42
SelectCheckBoxElement.php:175ReplyDoneSelectCheckBoxElement.php:184ReplyDone -
core-ci voted on patch set 11 V +1 06/12/24, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59366
-
Jasmina Ließmann voted on patch set 11 CR +1 V +1 06/12/24, 20:17
-
Michael Telgkamp voted on patch set 11 CR +1 V +1 06/13/24, 10:35
-
Andreas Nedbal voted on patch set 11 CR +2 V +2 06/13/24, 10:39
-
Andreas Nedbal merged patch set 12 06/13/24, 10:39