Review main Merged

79703[TASK] Unify layout of SelectCheckBox group headers

Andreas Nedbal CR +2 V +2 Normal +92 −5 updated 06/13/24, 10:39

Commit message

Before it was not really clear if/where a select check box header
was collapsible. This patch unifies the layout with the one of the
recordlist tables, adding a button specifically responsible to
collapse/expand the group.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Jasmina Ließmann +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Jasmina Ließmann +1
    • Michael Telgkamp +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2839

Show 1014 earlier messages
  1. Andreas Nedbal uploaded patch set 1 07/04/23, 16:41

  2. core-ci voted on patch set 1 V +1 07/04/23, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43406

  3. Annett Jähnichen voted on patch set 1 V +1 07/04/23, 18:22

  4. Sybille Peters commented on patch set 1 V +1 07/06/23, 10:03

    I checked the "Explicitly allow field values" section in the BE groups. With the patch it now has an "expand" icon (v). Looks good. (will post my screenshots to issue)
  5. Oliver Hader commented on patch set 1 09/19/23, 17:39

    SelectCheckBoxElement.php:174

    `htmlspecialchars` should wrap the `sprintf` - otherwise `$group['header']['title']` would not be covered
  6. Andreas Nedbal rebased onto patch set 2 V +1 06/10/24, 13:57

    The following files contain Git conflicts: * typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php
  7. core-ci voted on patch set 2 V -1 06/10/24, 14:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59014

  8. Sybille Peters wrote 06/10/24, 14:21

    Removed reviewer Sybille Peters.
  9. Andreas Nedbal uploaded patch set 3 V -1 06/11/24, 07:45

  10. core-ci voted on patch set 3 V -1 06/11/24, 08:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59119

  11. Andreas Nedbal uploaded patch set 4 V -1 06/11/24, 09:57

  12. core-ci voted on patch set 4 V -1 06/11/24, 10:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59156

  13. Andreas Nedbal uploaded patch set 5 V -1 06/11/24, 11:06

  14. Andreas Nedbal uploaded patch set 6 06/11/24, 11:08

  1. core-ci voted on patch set 5 V -1 06/11/24, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59166

  2. core-ci voted on patch set 6 V -1 06/11/24, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59167

  3. Andreas Nedbal uploaded patch set 7 V -1 06/11/24, 11:51

  4. core-ci voted on patch set 7 V +1 06/11/24, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59174

  5. Andreas Nedbal marked it ready for review 06/11/24, 12:01

  6. Michael Telgkamp commented on patch set 7 CR +1 V +1 06/11/24, 13:17

    Thank you for the patch and the improvement of the accessibility by changing the element to a button.

    SelectCheckBoxElement.php:174 Reply

    Done
  7. Jasmina Ließmann voted on patch set 7 CR +1 V +1 06/11/24, 14:04

  8. Andreas Nedbal rebased onto patch set 8 CR +1 V +1 06/12/24, 16:39

    The following files contain Git conflicts: * Build/Sources/TypeScript/backend/form-engine/element/select-check-box-element.ts * typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-check-box-element.js
  9. core-ci voted on patch set 8 V -1 06/12/24, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59355

  10. Michael Telgkamp uploaded patch set 9 V -1 06/12/24, 17:34

  11. core-ci voted on patch set 9 V +1 06/12/24, 17:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59359

  12. Andreas Nedbal marked it ready for review 06/12/24, 17:43

  13. Michael Telgkamp voted on patch set 9 CR +1 V +1 06/12/24, 17:44

  14. Andreas Nedbal commented on patch set 9 V -1 06/12/24, 19:07

    on it
  15. Andreas Nedbal uploaded patch set 10 CR +1 V +1 06/12/24, 19:28

  16. core-ci voted on patch set 10 V +1 06/12/24, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59364

  17. Jasmina Ließmann commented on patch set 10 06/12/24, 19:34

    SelectCheckBoxElement.php:175

    Looks like it $title is unused and can be removed. The language key is also not available anymore.
  18. Jasmina Ließmann commented on patch set 10 06/12/24, 19:36

    SelectCheckBoxElement.php:184

    This div is never closed.
  19. Andreas Nedbal uploaded patch set 11 V +1 06/12/24, 19:41

  20. Andreas Nedbal commented on patch set 11 06/12/24, 19:42

    SelectCheckBoxElement.php:175 Reply

    Done

    SelectCheckBoxElement.php:184 Reply

    Done
  21. core-ci voted on patch set 11 V +1 06/12/24, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59366

  22. Jasmina Ließmann voted on patch set 11 CR +1 V +1 06/12/24, 20:17

  23. Michael Telgkamp voted on patch set 11 CR +1 V +1 06/13/24, 10:35

  24. Andreas Nedbal voted on patch set 11 CR +2 V +2 06/13/24, 10:39

  25. Andreas Nedbal merged patch set 12 06/13/24, 10:39