Review main Merged

79713[BUGFIX] Use event delegation for frontend links

Andreas Kienast CR +2 V +2 Normal +32 −43 updated 07/06/23, 06:27

Commit message

TYPO3 ships some default handling for encrypted email links and popup
windows. Unfortunately, only links that were available on initial
document load were handled, links that were added after couldn't get
handled.

To solve the issue, the events are not directly bound to such links
anymore, but handled by an event delegation approach.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Philipp Kitzberger +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Philipp Kitzberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Andreas Kienast uploaded patch set 1 07/05/23, 09:38

  2. core-ci voted on patch set 1 V +1 07/05/23, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43480

  3. Benjamin Franzke commented on patch set 1 CR -1 07/05/23, 11:20

    default_frontend.js:96

    ready() can now be dropped
  4. Benjamin Franzke uploaded patch set 2 CR -1 V +1 07/05/23, 11:36

  5. Benjamin Franzke commented on patch set 2 07/05/23, 11:36

    default_frontend.js:96 Reply

    Done
  6. core-ci voted on patch set 2 V +1 07/05/23, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43495

  7. Philipp Kitzberger commented on patch set 2 V +1 CR +1 07/05/23, 19:29

    Works like a charm on my v11 project.
  8. Georg Ringer voted on patch set 2 CR +1 07/06/23, 04:12

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 07/06/23, 06:27

  10. Andreas Kienast merged patch set 3 07/06/23, 06:27