Review main Merged

79717[BUGFIX] Do not show deleted page translation in page module in WS

Benni Mack CR +2 V +2 Easy +19 −7 updated 01/06/24, 20:37

Commit message

This change does not render a page translation anymore
if it was deleted (t3ver_state=2).

It also enables the dropdown to create a new page translation
but then DataHandler does not allow this anymore.

This patch needs more work in DataHandler for
"delete translation in WS + create a new translation in WS"

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Benni Mack uploaded patch set 1 07/05/23, 11:02

  2. core-ci voted on patch set 1 V +1 07/05/23, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43490

  3. Stefan Bürk rebased onto patch set 2 V +1 09/27/23, 15:12

  4. core-ci voted on patch set 2 V +1 09/27/23, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47254

  5. Stefan Bürk rebased onto patch set 3 V +1 12/18/23, 22:09

  6. core-ci voted on patch set 3 V +1 12/18/23, 22:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50774

  7. Oli Bartsch voted on patch set 3 CR +1 01/01/24, 20:29

  8. Oli Bartsch voted on patch set 3 V +1 01/05/24, 09:04

  9. Stefan Bürk voted on patch set 3 CR +1 V +1 01/06/24, 12:26

  10. Benni Mack commented on patch set 3 01/06/24, 20:37

    I created https://forge.typo3.org/issues/102768 for a followup
  11. Benni Mack voted on patch set 3 CR +2 V +2 01/06/24, 20:37

  12. Benni Mack merged patch set 4 01/06/24, 20:37