Review main Merged

79723[BUGFIX] Show warning if TSconfig is set to circular dependency

Benni Mack CR +2 V +2 Easy +24 −2 updated 07/05/23, 20:12

Commit message

When using TSconfig like this:

mod.web_list.tableDisplayOrder.pages {
   after = tt_content
}

which creates a circular dependency with the original TSconfig,
the list module does not crash anymore but shows a warning
instead.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Benni Mack uploaded patch set 1 07/05/23, 12:36

  2. core-ci voted on patch set 1 V +1 07/05/23, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43508

  3. Susi Moog voted on patch set 1 CR +1 07/05/23, 18:38

  4. Benni Mack updated the commit message in patch set 2 CR +1 V +1 07/05/23, 18:41

  5. Benni Mack commented on patch set 2 07/05/23, 18:41

    needs LLL files
  6. core-ci voted on patch set 2 V +1 07/05/23, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43589

  7. Susi Moog uploaded patch set 3 V +1 07/05/23, 19:04

  8. core-ci voted on patch set 3 V +1 07/05/23, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43598

  9. Susi Moog voted on patch set 3 V +1 CR +1 07/05/23, 19:29

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 07/05/23, 19:59

  11. Benni Mack voted on patch set 3 V +2 CR +2 07/05/23, 20:12

  12. Benni Mack merged patch set 4 07/05/23, 20:12