Review main Abandoned

79729[FEATURE] Make default search level in list module configurable

Andreas Nedbal CR 0 V 0 Normal +54 −2 updated 06/11/24, 08:12

Commit message

Before, the search level was always set to "1 level down" by default.
New page and user TSconfig settings now allow setting a different
default value.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1217

  1. Andreas Nedbal uploaded patch set 1 07/05/23, 15:29

  2. core-ci voted on patch set 1 V -1 07/05/23, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43546

  3. Andreas Nedbal uploaded patch set 2 V -1 07/05/23, 15:48

  4. core-ci voted on patch set 2 V +1 07/05/23, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43551

  5. Benni Mack commented on patch set 2 08/10/23, 11:30

    Can you make one RST out of it "New TSconfig option to define default searchLevel in listings of records" or something like that
  6. Andreas Nedbal commented on patch set 2 08/10/23, 12:05

    Reply

    Ack
  7. Andreas Nedbal rebased onto patch set 3 V +1 09/21/23, 07:55

  8. core-ci voted on patch set 3 V +1 09/21/23, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46974

  9. Andreas Nedbal uploaded patch set 4 V +1 09/21/23, 08:03

  10. Andreas Nedbal commented on patch set 4 09/21/23, 08:04

    Reply

    Done
  11. core-ci voted on patch set 4 V +1 09/21/23, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46975

  12. Chris Müller commented on patch set 4 CR -1 09/21/23, 08:16

    Feature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:7

    The "=" must have the same length as the text.

    Feature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:18

    I assume there must be an empty line before the list to be rendered correctly.

    Feature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:30

    User TSconfig:

    Feature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:39

    Page TSconfig:
  13. Andreas Nedbal uploaded patch set 5 CR -1 V +1 09/21/23, 08:18

  14. Andreas Nedbal commented on patch set 5 09/21/23, 08:19

    Feature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:7 Reply

    Done

    Feature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:18 Reply

    Done

    Feature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:30 Reply

    Done

    Feature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:39 Reply

    Done
  15. core-ci voted on patch set 5 V +1 09/21/23, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46982

  16. Oli Bartsch commented on patch set 5 CR -1 09/21/23, 09:22

    Unresolved

    Should the new option be respected by the TableListViewHelper ("levels" argument) as well?

    Feature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:6 Unresolved

    default search level

    Feature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:19 Unresolved

    Please not introduce two separate options for the same functionality. Only add one option, e.g. the Page TSconfig option could be overwritten with "page.*" User TSconfig anyways. However since we use the option at different places (not only in the record list module), I prefer to only introduce a User TSconfig option.
  17. Andreas Nedbal abandoned the change 06/11/24, 08:12

    Superseeded by 84009