79729[FEATURE] Make default search level in list module configurable
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 1217
-
Andreas Nedbal uploaded patch set 1 07/05/23, 15:29
-
core-ci voted on patch set 1 V -1 07/05/23, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43546
-
Andreas Nedbal uploaded patch set 2
V -107/05/23, 15:48 -
core-ci voted on patch set 2 V +1 07/05/23, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43551
-
Benni Mack commented on patch set 2 08/10/23, 11:30
Can you make one RST out of it "New TSconfig option to define default searchLevel in listings of records" or something like that -
Andreas Nedbal commented on patch set 2 08/10/23, 12:05
Reply
Ack -
Andreas Nedbal rebased onto patch set 3
V +109/21/23, 07:55 -
core-ci voted on patch set 3 V +1 09/21/23, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46974
-
Andreas Nedbal uploaded patch set 4
V +109/21/23, 08:03 -
Andreas Nedbal commented on patch set 4 09/21/23, 08:04
Reply
Done -
core-ci voted on patch set 4 V +1 09/21/23, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46975
-
Chris Müller commented on patch set 4 CR -1 09/21/23, 08:16
Feature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:7The "=" must have the same length as the text.Feature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:18I assume there must be an empty line before the list to be rendered correctly.Feature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:30User TSconfig:Feature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:39Page TSconfig: -
Andreas Nedbal uploaded patch set 5
CR -1V +109/21/23, 08:18 -
Andreas Nedbal commented on patch set 5 09/21/23, 08:19
Feature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:7ReplyDoneFeature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:18ReplyDoneFeature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:30ReplyDoneFeature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:39ReplyDone -
core-ci voted on patch set 5 V +1 09/21/23, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46982
-
Oli Bartsch commented on patch set 5 CR -1 09/21/23, 09:22
Unresolved
Should the new option be respected by the TableListViewHelper ("levels" argument) as well?Feature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:6Unresolveddefault search levelFeature-96629-TSconfigOptionsdefaultSearchLevelAdded.rst:19UnresolvedPlease not introduce two separate options for the same functionality. Only add one option, e.g. the Page TSconfig option could be overwritten with "page.*" User TSconfig anyways. However since we use the option at different places (not only in the record list module), I prefer to only introduce a User TSconfig option. -
Andreas Nedbal abandoned the change 06/11/24, 08:12
Superseeded by 84009