Review main Merged

79730[BUGFIX] Prevent PHP warnings in IconFactory for tables with missing "ctrl"

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 07/05/23, 18:28

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1417

  1. Oli Bartsch uploaded patch set 1 07/05/23, 15:34

  2. core-ci voted on patch set 1 V -1 07/05/23, 15:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43547

  3. Oliver Klee voted on patch set 1 CR +1 07/05/23, 16:02

  4. Oliver Klee commented on patch set 1 07/05/23, 16:02

    Should we also target 11.5?
  5. Susi Moog voted on patch set 1 V +1 CR +1 07/05/23, 16:13

  6. Oli Bartsch commented on patch set 1 07/05/23, 16:15

    Reply

    No this is no priority bugfix.
  7. Benni Mack rebased onto patch set 2 CR +1 V +1 07/05/23, 16:22

  8. core-ci voted on patch set 2 V +1 07/05/23, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43557

  9. Oliver Klee voted on patch set 2 CR +1 07/05/23, 16:39

  10. Benni Mack voted on patch set 2 V +1 CR +1 07/05/23, 17:07

  11. Benni Mack updated the commit message in patch set 3 CR +1 V +1 07/05/23, 17:07

  12. core-ci voted on patch set 3 V +1 07/05/23, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43562

  13. Andreas Kienast voted on patch set 3 V +1 CR +1 07/05/23, 17:24

  14. Oliver Klee voted on patch set 3 CR +1 07/05/23, 18:20

  15. Benni Mack voted on patch set 3 V +1 CR +1 07/05/23, 18:26

  16. Oli Bartsch voted on patch set 3 V +2 CR +2 07/05/23, 18:28

  17. Oli Bartsch merged patch set 4 07/05/23, 18:28