Review main Merged

79753[BUGFIX] Respect `data-content` for modals again

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 07/11/23, 09:19

Commit message

With the upgrade to Bootstrap 5, modals unintentionally don't support
the `data-content` attribute anymore as this was automatically migrated
to the namespaced variant `data-bs-content`. While this is technically
correct for Bootstrap 5, Core still needs to support the old variant as
documented.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Andreas Kienast uploaded patch set 1 07/05/23, 17:18

  2. core-ci voted on patch set 1 V +1 07/05/23, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43565

  3. Benni Mack voted on patch set 1 V +1 CR +1 07/05/23, 17:31

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 07/11/23, 09:19

  5. Oli Bartsch merged patch set 2 07/11/23, 09:19