Review main Merged

79757[BUGFIX] Add FROM part to count query in SuggestWizardDefaultReceiver

Christoph Lehmann CR +2 V +2 Easy +1 −0 updated 07/06/23, 07:59

Commit message

This resolves the exception Unknown column 'uid' in 'field list' when using the suggest wizard (For example at field 'shortcut' in pages table)

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Christoph Lehmann uploaded patch set 1 07/05/23, 18:02

  2. Christoph Lehmann updated the commit message in patch set 2 07/05/23, 18:05

  3. core-ci voted on patch set 1 V +1 07/05/23, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43577

  4. core-ci voted on patch set 2 V +1 07/05/23, 18:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43578

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 07/05/23, 18:16

  6. Oliver Klee commented on patch set 2 07/05/23, 18:16

    Is it certain that 12.4 and 11.5 are not affected?
  7. Christoph Lehmann commented on patch set 2 07/05/23, 20:00

    Reply

    I think https://review.typo3.org/c/Packages/TYPO3.CMS/+/79137 was the introducing change, which went on main only, on 8th June. So yes.
  8. Benni Mack voted on patch set 2 V +2 CR +2 07/06/23, 07:59

  9. Benni Mack merged patch set 3 07/06/23, 07:59