Review main Merged

79758[TASK] Streamline backend password reset log message

Torben Hansen CR +2 V +2 Easy +1 −1 updated 07/06/23, 16:57

Commit message

The current backend password reset log message misses a `}` and logs
the `user_id` if a password has been reset successfully. Logging the
`user_id` is however not inline with other user related log messages,
where always the `username` is logged.

This patch streamlines the log message with other user related log
messages by including the `username` instead of the `user_id`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Torben Hansen uploaded patch set 1 07/05/23, 20:28

  2. Benni Mack commented on patch set 1 07/05/23, 20:45

    PasswordReset.php:358

    I think we should add both the user id and the username to the context (second argument)
  3. core-ci voted on patch set 1 V -1 07/05/23, 20:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43619

  4. Torben Hansen uploaded patch set 2 V -1 07/05/23, 21:04

  5. Torben Hansen commented on patch set 2 07/05/23, 21:32

    PasswordReset.php:358 Reply

    Done
  6. core-ci voted on patch set 2 V -1 07/05/23, 22:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43639

  7. Torben Hansen rebased onto patch set 3 V -1 07/06/23, 08:42

  8. Benni Mack rebased onto patch set 4 07/06/23, 10:24

  9. core-ci voted on patch set 4 V +1 07/06/23, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43688

  10. Benni Mack voted on patch set 4 V +1 CR +1 07/06/23, 12:40

  11. Frank Nägler voted on patch set 4 V +1 CR +1 07/06/23, 16:56

  12. Benni Mack voted on patch set 4 V +2 CR +2 07/06/23, 16:57

  13. Benni Mack merged patch set 5 07/06/23, 16:57