Review main Merged

79760[BUGFIX] Fix documentation of "show dialog" in Workspaces

TYPO3com CR +2 V +2 Easy +4 −3 updated 07/06/23, 07:08

Commit message

The "show dialog" option is an option
below the notification settings of
each workspace and therefor only impacts the notification settings.
A dialog will still appear, allowing the user to add a comment.
The documentation now reflects this.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 611

  1. TYPO3com uploaded patch set 1 07/05/23, 21:02

  2. Susi Moog updated the commit message in patch set 2 07/05/23, 21:03

  3. Susi Moog updated the commit message in patch set 3 07/05/23, 21:04

  4. Susi Moog updated the commit message in patch set 4 07/05/23, 21:05

  5. core-ci voted on patch set 1 V +1 07/05/23, 21:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43636

  6. core-ci voted on patch set 3 V -1 07/05/23, 21:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43638

  7. core-ci voted on patch set 2 V +1 07/05/23, 21:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43637

  8. core-ci voted on patch set 4 V +1 07/05/23, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43640

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 07/06/23, 06:29

  10. Benni Mack voted on patch set 4 V +2 CR +2 07/06/23, 07:08

  11. Benni Mack merged patch set 5 07/06/23, 07:08