Review main Merged

79763[BUGFIX] Provide shortcut button for "Today" in date picker

Andreas Kienast CR +2 V +2 Normal +81 −1 updated 07/07/23, 20:19

Commit message

flatpickr doesn't provide an easy possibility to set the today's date.
To solve this issue, the plugin `shortcut-buttons-flatpickr` is added
with a configuration for the today's date.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1421

  1. Andreas Kienast uploaded patch set 1 07/06/23, 07:05

  2. Andreas Kienast uploaded patch set 2 07/06/23, 07:09

  3. core-ci voted on patch set 1 V -1 07/06/23, 07:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43658

  4. Andreas Kienast uploaded patch set 3 07/06/23, 07:24

  5. core-ci voted on patch set 2 V -1 07/06/23, 07:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43661

  6. core-ci voted on patch set 3 V +1 07/06/23, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43664

  7. Benni Mack updated the commit message in patch set 4 V +1 07/06/23, 16:53

  8. core-ci voted on patch set 4 V +1 07/06/23, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43775

  9. Andreas Kienast uploaded patch set 5 V +1 07/07/23, 08:50

  10. core-ci voted on patch set 5 V +1 07/07/23, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43873

  11. Andreas Nedbal commented on patch set 5 07/07/23, 09:36

    date-time-picker.ts:206

    This button label should be localized.
  12. Benjamin Franzke commented on patch set 5 07/07/23, 10:38

    _datetimepicker.scss:642

    I think we need a proper on-dark button style here. @Benji?
  13. Andreas Kienast commented on patch set 5 07/07/23, 11:05

    date-time-picker.ts:206 Reply

    Ack
  14. Benjamin Kott uploaded patch set 6 V +1 07/07/23, 12:15

  15. Benjamin Kott commented on patch set 6 07/07/23, 12:21

    _datetimepicker.scss:642 Reply

    resolved
  16. core-ci voted on patch set 6 V +1 07/07/23, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43901

  17. Andreas Kienast uploaded patch set 7 V +1 07/07/23, 12:44

  18. core-ci voted on patch set 7 V +1 07/07/23, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43905

  19. Markus Klein voted on patch set 7 V +1 CR +1 07/07/23, 18:56

  20. Benjamin Franzke commented on patch set 7 V +2 CR +2 07/07/23, 20:19

    _datetimepicker.scss:642 Reply

    Thank you!
  21. Benjamin Franzke merged patch set 8 07/07/23, 20:19