Review 12.4 Merged

79787[BUGFIX] Do not abort renameFile if filename sanitizable

Andreas Kienast CR +2 V +2 Easy +41 −3 updated 07/06/23, 20:12

Commit message

It is possible to rename a file with ResourseStorage::renameFile(). This
is also used under the hood, if a file is renamed in the file list.

RenameFile also performs a sanitation of the filename, in case the
filename was not yet sanitized (e.g. convert chars like space, quote,
ö, ê, ß or §).

But if the target filename is the same as the current filename, the
sanitation was not performed. This is now fixed so that the behaviour
is more consistent and sanitizing files with renameFile() is possible.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Andreas Kienast commented on patch set 1 07/06/23, 07:55

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/06/23, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43665

  3. Benni Mack voted on patch set 1 V +2 CR +2 07/06/23, 20:12

  4. Benni Mack merged patch set 2 07/06/23, 20:12