Review main Merged

79800[BUGFIX] Ensure DateTime conversion does not throw an error

Benni Mack CR +2 V +2 Normal +79 −4 updated 07/06/23, 20:07

Commit message

When DataHandler is used to import data from the $dataMap
and a field with dbType="date" is filled with a timestamp,
it is not properly converted.

This change adapts this.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Frank Nägler +1

Issues 1

Files 3

Review log 1519

  1. Benni Mack uploaded patch set 1 07/06/23, 12:46

  2. Benni Mack marked it work in progress 07/06/23, 12:46

  3. core-ci voted on patch set 1 V +1 07/06/23, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43733

  4. Andreas Wolf commented on patch set 1 07/06/23, 15:26

    DataHandler.php:2195

    Can't we just cast to an integer here and spare ourselves the case to DateTime?
  5. Andreas Wolf uploaded patch set 2 V +1 07/06/23, 15:29

  6. Andreas Wolf uploaded patch set 3 07/06/23, 15:30

  7. core-ci voted on patch set 2 V +1 07/06/23, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43765

  8. core-ci voted on patch set 3 V -1 07/06/23, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43766

  9. Benni Mack commented on patch set 3 07/06/23, 19:20

    DataHandler.php:2195 Reply

    true that. interesting!
  10. Andreas Wolf uploaded patch set 4 V -1 07/06/23, 19:42

  11. Benni Mack uploaded patch set 5 07/06/23, 19:48

  12. Benni Mack marked it ready for review 07/06/23, 19:48

  13. Frank Nägler voted on patch set 5 CR +1 07/06/23, 19:50

  14. Frank Nägler voted on patch set 5 V +1 07/06/23, 19:58

  15. core-ci voted on patch set 4 V +1 07/06/23, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43816

  16. Benjamin Franzke voted on patch set 5 CR +1 07/06/23, 20:02

  17. Benjamin Franzke voted on patch set 5 V +2 CR +2 07/06/23, 20:05

  18. Benjamin Franzke merged patch set 6 07/06/23, 20:06

  19. Oli Bartsch voted on patch set 6 V +1 CR +1 07/06/23, 20:07