Review main Merged

79801[BUGFIX] Support union types for event listeners

Oli Bartsch CR +2 V +2 Normal +40 −20 updated 07/06/23, 13:57

Commit message

Since #94345 it's possible to omit the "event"
identifier when configuring an event listener,
since the service can be resolved using reflection.
This however did until now not work when using
union types. This patch therefore adjusts the
corresponding compiler pass, making it possible
to use the same method for listing on multiple
events.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 810

  1. Oli Bartsch uploaded patch set 1 07/06/23, 13:00

  2. core-ci voted on patch set 1 V +1 07/06/23, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43735

  3. Andreas Kienast commented on patch set 1 07/06/23, 13:12

    ListenerProviderPass.php:136

    method\'s
  4. Oli Bartsch uploaded patch set 2 V +1 07/06/23, 13:15

  5. Oli Bartsch commented on patch set 2 07/06/23, 13:15

    ListenerProviderPass.php:136 Reply

    Done
  6. Andreas Kienast commented on patch set 2 V +1 CR +1 07/06/23, 13:15

    ListenerProviderPass.php:136 Reply

    Done
  7. core-ci voted on patch set 2 V +1 07/06/23, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43740

  8. Benni Mack voted on patch set 2 V +1 CR +1 07/06/23, 13:35

  9. Oli Bartsch voted on patch set 2 V +2 CR +2 07/06/23, 13:57

  10. Oli Bartsch merged patch set 3 07/06/23, 13:57