Review 12.4 Merged

79802[BUGFIX] Repair installtool core updater button callback

Benjamin Franzke CR +2 V +2 Easy +7 −10 updated 07/28/23, 17:36

Commit message

Button data attributes have been removed from th modal API
and are therefore not automatically assigned.
Instead of an initial and explicit data-action attribute,
we rather imply that the initial intention of the
"Check for core updates" is to check for updates,
and therefore use data-action only for subsequent actions.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Benjamin Franzke uploaded patch set 1 07/06/23, 13:20

  2. Benjamin Franzke marked it work in progress 07/06/23, 13:25

  3. core-ci voted on patch set 1 V +1 07/06/23, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43741

  4. Benjamin Franzke marked it ready for review 07/06/23, 13:33

  5. Andreas Kienast voted on patch set 1 CR +1 07/06/23, 13:46

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 07/28/23, 17:36

  7. Christian Kuhn merged patch set 2 07/28/23, 17:36