Review main Merged

79803[BUGFIX] Repair installtool core updater button callback

Benjamin Franzke CR +2 V +2 Easy +7 −10 updated 07/28/23, 17:36

Commit message

Button data attributes have been removed from th modal API
and are therefore not automatically assigned.
Instead of an initial and explicit data-action attribute,
we rather imply that the initial intention of the
"Check for core updates" is to check for updates,
and therefore use data-action only for subsequent actions.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1416

  1. Benjamin Franzke uploaded patch set 1 07/06/23, 13:22

  2. Benjamin Franzke commented on patch set 1 CR -1 07/06/23, 13:25

    not working, sorry
  3. Benjamin Franzke marked it work in progress 07/06/23, 13:25

  4. core-ci voted on patch set 1 V -1 07/06/23, 13:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43742

  5. Benjamin Franzke commented on patch set 1 07/06/23, 13:33

    This change is ready for review.
    nevermind, works – I had local caching issues. Make sure to clear browser caches.
  6. Benjamin Franzke commented on patch set 1 CR 0 07/06/23, 13:33

    Please test by applying the v12 backport to a local 12.4.1 instance (so you're actually able to update to 12.4.2)
  7. Benjamin Franzke uploaded patch set 2 V -1 07/06/23, 13:41

  8. core-ci voted on patch set 2 V +1 07/06/23, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43746

  9. Andreas Kienast voted on patch set 2 CR +1 07/06/23, 13:56

  10. Oli Bartsch voted on patch set 2 CR +1 07/06/23, 14:45

  11. Christian Kuhn voted on patch set 2 CR +1 07/19/23, 09:00

  12. Benjamin Franzke commented on patch set 2 07/28/23, 11:01

    bump. we received new issues on this topic: https://forge.typo3.org/issues/101473
  13. Andreas Kienast voted on patch set 2 V +1 07/28/23, 12:55

  14. Stefan Bürk voted on patch set 2 V +1 CR +1 07/28/23, 17:36

  15. Christian Kuhn voted on patch set 2 V +2 CR +2 07/28/23, 17:36

  16. Christian Kuhn merged patch set 3 07/28/23, 17:36