Review main Merged

79805[BUGFIX] Properly handle user logged in tasks with MFA enabled

Oli Bartsch CR +2 V +2 Easy +29 −14 updated 07/06/23, 14:59

Commit message

In case a user has MFA enabled, the same handling
is now done as for users, not having MFA enabled.

This is e.g. dispatching the AfterUserLoggedInEvent.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 78

  1. Oli Bartsch uploaded patch set 1 07/06/23, 13:50

  2. core-ci voted on patch set 1 V +1 07/06/23, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43748

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 07/06/23, 13:57

  4. Benjamin Franzke voted on patch set 1 CR +1 07/06/23, 14:17

  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 07/06/23, 14:18

  6. Benjamin Franzke merged patch set 2 07/06/23, 14:18

  7. Oliver Hader commented on patch set 1 07/06/23, 14:22

    BackendUserAuthentication.php:2045

    Please add a guard for `$this->loginSessionStarted` and exit early, if it's not the case...
  8. Oliver Hader commented on patch set 2 07/06/23, 14:59

    BackendUserAuthentication.php:2045 Reply

    skipped