Review 12.4 Merged

79817[BUGFIX] Change column metaphone to varchar

Benni Mack CR +2 V +2 Easy +1 −1 updated 07/06/23, 14:12

Commit message

In case of activated STRICT_TRANS_TABLES, better known as strict_mode,
the index_words record incl. metaphone can not be stored as a string
is provided, but an int is expected.
As various metaphone related methods in TYPO3 return a string
we change the DB type of column metaphone to varchar. We set
the length to 60 as it is the same we use in analyzeHeaderinfo().

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Benni Mack commented on patch set 1 07/06/23, 12:35

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 07/06/23, 13:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43727

  3. Benni Mack rebased onto patch set 2 V -1 07/06/23, 13:35

  4. core-ci voted on patch set 2 V +1 07/06/23, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43745

  5. Benni Mack voted on patch set 2 V +2 CR +2 07/06/23, 14:12

  6. Benni Mack merged patch set 3 07/06/23, 14:12