79832[TASK] Raise 'phpstan/phpstan' and regenerate baseline
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 45
-
Wouter Wolters uploaded patch set 1 07/06/23, 16:59
-
core-ci voted on patch set 1 V -1 07/06/23, 17:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43778
-
Oliver Klee commented on patch set 1 07/08/23, 07:56
When I updated to 1.10.25 on my local machine, I didn't get any changes to the baseline. So I guess something is different between our two machines. ;-) -
Christian Kuhn commented on patch set 1 07/19/23, 08:48
we usually work like this with phpstan: there is a 'composer update max' in nightly - if phpstan releases and if this triggers baseline changes, the nightly fails. we *then* update phpstan. as such, we can just keep phpstan as-is, and push raises whenever nightly goes red instead. i hope it's ok to abandon for the time being. -
Christian Kuhn abandoned the change 07/19/23, 08:48