Review main Merged

79834[TASK] Remove jQuery from ImageProcessing

Oli Bartsch CR +2 V +2 Normal +36 −30 updated 07/07/23, 10:35

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Oli Bartsch uploaded patch set 1 07/06/23, 17:33

  2. core-ci voted on patch set 1 V -1 07/06/23, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43785

  3. Oli Bartsch rebased onto patch set 2 V -1 07/06/23, 17:54

  4. Oli Bartsch uploaded patch set 3 07/06/23, 17:54

  5. core-ci voted on patch set 3 V +1 07/06/23, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43791

  6. Andreas Kienast uploaded patch set 4 V +1 07/07/23, 07:33

  7. Andreas Kienast voted on patch set 4 V +1 CR +1 07/07/23, 07:33

  8. core-ci voted on patch set 4 V +1 07/07/23, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43855

  9. Benjamin Franzke commented on patch set 4 CR +1 07/07/23, 10:01

    image-processing.ts:105 Unresolved

    I don't like that we pass unescaped text to innerHTML later, but has been the case before as well, AFAICS.
  10. Benjamin Franzke voted on patch set 4 V +2 CR +2 07/07/23, 10:35

  11. Benjamin Franzke merged patch set 5 07/07/23, 10:35