Review main Merged

79847[TASK] Revert "[BUGFIX] Ensure DateTime conversion does not throw an error"

Benjamin Franzke CR +2 V +2 Normal +4 −79 updated 07/07/23, 04:25

Commit message

This reverts commit aa956a53c2cebe3d44f99368941c3d8c348ee8b7.
It has been merged before CI run was completed
and the test itself is fine, but the fixture caused
side effects for other functional tests.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 57

  1. Benjamin Franzke uploaded patch set 1 07/06/23, 21:18

  2. Oliver Klee voted on patch set 1 V +1 CR +1 07/06/23, 21:22

  3. core-ci voted on patch set 1 V -1 07/06/23, 21:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43838

  4. Benjamin Franzke uploaded patch set 2 CR +1 V +1 07/06/23, 21:42

  5. core-ci voted on patch set 2 V +1 07/06/23, 21:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43841

  6. Benjamin Franzke merged patch set 3 07/06/23, 21:59

  7. Simon Schaufelberger commented on patch set 3 07/07/23, 04:25

    Unresolved

    Is there a fix coming up for this?