79848[!!!][TASK] Introduce type declarations in ResourceInterface
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Tests/Unit/Controller/File/FileControllerTest.php+4 −1
- typo3/sysext/core/Classes/Resource/AbstractFile.php+6 −26
- typo3/sysext/core/Classes/Resource/FileReference.php+7 −21
- typo3/sysext/core/Classes/Resource/Folder.php+6 −22
- typo3/sysext/core/Classes/Resource/ProcessedFile.php+4 −4
- typo3/sysext/core/Classes/Resource/ResourceInterface.php+10 −31
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-101281-IntroduceTypeDeclarationsInResourceInterface.rstnew+85 −0
- typo3/sysext/core/Tests/Unit/LinkHandling/FileLinkHandlerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/LinkHandling/LegacyLinkNotationConverterTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/AbstractFileTest.php+3 −2
Review log 912
-
Alexander Schnitzler uploaded patch set 1 07/07/23, 05:31
-
Alexander Schnitzler wrote 07/07/23, 05:31
Topic set to FAL -
core-ci voted on patch set 1 V -1 07/07/23, 05:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43849
-
Alexander Schnitzler uploaded patch set 2
V -107/07/23, 06:04 -
Alexander Schnitzler rebased onto patch set 3 07/07/23, 06:06
-
core-ci voted on patch set 3 V +1 07/07/23, 06:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43851
-
Alexander Schnitzler marked it ready for review 07/07/23, 06:17
-
core-ci voted on patch set 2 V +1 07/07/23, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43850
-
Oliver Klee voted on patch set 3 V +1 07/08/23, 07:26
-
Oliver Klee voted on patch set 3 CR +1 07/08/23, 07:27
-
Benni Mack voted on patch set 3 V +2 CR +2 07/08/23, 11:44
-
Benni Mack merged patch set 4 07/08/23, 11:44