Review main Merged Breaking

79848[!!!][TASK] Introduce type declarations in ResourceInterface

Alexander Schnitzler CR +2 V +2 Normal +129 −111 updated 07/08/23, 11:44

Commit message

This change introduces return type declarations of methods
of the ResourceInterface.

This affects many classes due to the following implementation
rules:

- \TYPO3\CMS\Core\Resource\Folder, because it implements
  \TYPO3\CMS\Core\Resource\FolderInterface which extends
  \TYPO3\CMS\Core\Resource\ResourceInterface

- \TYPO3\CMS\Core\Resource\FileReference, and
  \TYPO3\CMS\Core\Resource\AbstractFile because both implement
  \TYPO3\CMS\Core\Resource\FileInterface which extends
  \TYPO3\CMS\Core\Resource\ResourceInterface

- \TYPO3\CMS\Core\Resource\File and \TYPO3\CMS\Core\Resource\ProcessedFile
  because both extend \TYPO3\CMS\Core\Resource\AbstractFile

In consequence, the following methods are affected:

- \TYPO3\CMS\Core\Resource\Folder::getIdentifier()
- \TYPO3\CMS\Core\Resource\Folder::getName()
- \TYPO3\CMS\Core\Resource\Folder::getStorage()
- \TYPO3\CMS\Core\Resource\Folder::getHashedIdentifier()
- \TYPO3\CMS\Core\Resource\Folder::getParentFolder()
- \TYPO3\CMS\Core\Resource\FileReference::getIdentifier()
- \TYPO3\CMS\Core\Resource\FileReference::getName()
- \TYPO3\CMS\Core\Resource\FileReference::getStorage()
- \TYPO3\CMS\Core\Resource\FileReference::getHashedIdentifier()
- \TYPO3\CMS\Core\Resource\FileReference::getParentFolder()
- \TYPO3\CMS\Core\Resource\AbstractFile::getIdentifier()
- \TYPO3\CMS\Core\Resource\AbstractFile::getName()
- \TYPO3\CMS\Core\Resource\AbstractFile::getStorage()
- \TYPO3\CMS\Core\Resource\AbstractFile::getHashedIdentifier()
- \TYPO3\CMS\Core\Resource\AbstractFile::getParentFolder()
- \TYPO3\CMS\Core\Resource\File::getIdentifier()
- \TYPO3\CMS\Core\Resource\File::getName()
- \TYPO3\CMS\Core\Resource\File::getStorage()
- \TYPO3\CMS\Core\Resource\File::getHashedIdentifier()
- \TYPO3\CMS\Core\Resource\File::getParentFolder()
- \TYPO3\CMS\Core\Resource\ProcessedFile::getIdentifier()
- \TYPO3\CMS\Core\Resource\ProcessedFile::getName()
- \TYPO3\CMS\Core\Resource\ProcessedFile::getStorage()
- \TYPO3\CMS\Core\Resource\ProcessedFile::getHashedIdentifier()
- \TYPO3\CMS\Core\Resource\ProcessedFile::getParentFolder()

This might affect user land code if any of those mentioned
interfaces are implemented or any of those classes are extended.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 912

  1. Alexander Schnitzler uploaded patch set 1 07/07/23, 05:31

  2. Alexander Schnitzler wrote 07/07/23, 05:31

    Topic set to FAL
  3. core-ci voted on patch set 1 V -1 07/07/23, 05:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43849

  4. Alexander Schnitzler uploaded patch set 2 V -1 07/07/23, 06:04

  5. Alexander Schnitzler rebased onto patch set 3 07/07/23, 06:06

  6. core-ci voted on patch set 3 V +1 07/07/23, 06:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43851

  7. Alexander Schnitzler marked it ready for review 07/07/23, 06:17

  8. core-ci voted on patch set 2 V +1 07/07/23, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43850

  9. Oliver Klee voted on patch set 3 V +1 07/08/23, 07:26

  10. Oliver Klee voted on patch set 3 CR +1 07/08/23, 07:27

  11. Benni Mack voted on patch set 3 V +2 CR +2 07/08/23, 11:44

  12. Benni Mack merged patch set 4 07/08/23, 11:44