Review main Merged

79850[BUGFIX] Remove pagination arrows from translations files

Benjamin Kott CR +2 V +2 Easy +4 −4 updated 07/07/23, 08:27

Commit message

We are removing the pagination arrows from the translation
files since they needed to be marked with "aria-hidden" to
avoid acessibility issues. This would extend the usage of
markup that should not  be placed in translation files in the
first place. To allow integrators to change the apperance we
are now adding css classes that can be used to apply
special styling for the next and previous links.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Benjamin Kott uploaded patch set 1 07/07/23, 07:43

  2. core-ci voted on patch set 1 V +1 07/07/23, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43858

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 07/07/23, 07:53

  4. Oliver Klee voted on patch set 1 CR +1 07/07/23, 08:03

  5. Georg Ringer voted on patch set 1 V +1 CR +1 07/07/23, 08:25

  6. Benjamin Kott voted on patch set 1 V +2 CR +2 07/07/23, 08:26

  7. Benjamin Kott merged patch set 2 07/07/23, 08:26

  8. Georg Ringer commented on patch set 1 V +1 CR +1 07/07/23, 08:26

    just to document it: this is a change in behavior in Frontend which we usually don't do! at least it should be documented in release notes